From owner-svn-src-all@freebsd.org Mon Jan 15 13:29:24 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4FD7BE7D267; Mon, 15 Jan 2018 13:29:24 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com [209.85.215.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 04E2874BA1; Mon, 15 Jan 2018 13:29:23 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lf0-f48.google.com with SMTP id m8so13366345lfc.6; Mon, 15 Jan 2018 05:29:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5BeuOAHkCtCvqwvVErPtymSJsQJfVkhT82lixN4KV58=; b=fuLpwgqLQ3j3YKJ/Tj0vOCjz5uEOn0HEkFTVDuhi4r6ymZ7QRniM+HOADdjRVtCxcR K/vlDDLqqCYxhKEHexI6mYEOvQAwGsti9uWL/qzKXbBugRvKFABnDrPc4UNIrcGKMsdo p1Sq8ARX4nY4YGfJriVTTI6JDy4NLbw9uXInG1Ws5V5Nmopb/XIDOMJAv87Vg3Pf0nCM yTTGaroTGtjtetCKr5GZObIIOnQru/pfSKWUjlQWVh/37HUJDP6VL1+yKd9Qc+PQAaYZ gSBO1pbendVi0ZAPMDyXbkJb8hdMJhdaZHLQdS6qtuA+lfstthMVsoId7AUDMLr13QJ6 Aw+A== X-Gm-Message-State: AKwxytfM21/jzYIV5f5W9SyNGxNNyapusjDABH3g/LEGhmODC/1rzgFe 8BFWvwimRz252xI8Wp/TXK5q4RVr X-Google-Smtp-Source: ACJfBouNHgeXmKO11Hhp4GBpSPlLAktd2KktWXmAzfGkqstGbGYB30rWhQ1AxYRSwFQV+3Y7z+g1kw== X-Received: by 10.25.147.139 with SMTP id w11mr14365524lfk.58.1516021061380; Mon, 15 Jan 2018 04:57:41 -0800 (PST) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id r26sm4841646lfd.49.2018.01.15.04.57.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 04:57:40 -0800 (PST) Subject: Re: svn commit: r327996 - in head/sys: cam/scsi geom To: Konstantin Belousov Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201801151120.w0FBK0Jf006161@repo.freebsd.org> <20180115122556.GH1684@kib.kiev.ua> From: Andriy Gapon Message-ID: <71909368-67b8-6cfc-6e84-3750ed75e607@FreeBSD.org> Date: Mon, 15 Jan 2018 14:57:39 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180115122556.GH1684@kib.kiev.ua> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 13:29:24 -0000 On 15/01/2018 14:25, Konstantin Belousov wrote: > On Mon, Jan 15, 2018 at 11:20:00AM +0000, Andriy Gapon wrote: >> Author: avg >> Date: Mon Jan 15 11:20:00 2018 >> New Revision: 327996 >> URL: https://svnweb.freebsd.org/changeset/base/327996 >> >> Log: >> geom_disk / scsi_da: deny opening write-protected disks for writing >> >> Ths change consists of two parts. >> >> geom_disk: deny opening a disk for writing if it's marked as >> write-protected. A new disk(9) flag is added to mark write protected >> disks. A possible alternative could be to add another parameter to d_open, >> so that the open mode could be passed to it and the disk drivers could >> make the decision internally, but the flag required less churn. > > If you need the mode, use d_fdopen cdevsw method. Well, this is a GEOM class that does not have a cdev interface. -- Andriy Gapon