From owner-freebsd-net@FreeBSD.ORG Wed Oct 6 03:18:55 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDB73106564A; Wed, 6 Oct 2010 03:18:55 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id 718A48FC08; Wed, 6 Oct 2010 03:18:55 +0000 (UTC) Received: by qyk4 with SMTP id 4so188281qyk.13 for ; Tue, 05 Oct 2010 20:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=4C4THqw5CNhWyQ7HwNhUfdvm5kyUnwdOVgOyp8sx1Do=; b=b89eUk/Ito7D0+RuWsvzns0IjKCWMtAK3+3FF64TDG9Sgr1D6eUNjeshcYbSc/H5NW WtgZUv0Of0q/2f0E2PHq05jllNulTQtyj6gJnjtjekxXKAgS9GtpHYb7b2GHeSmh5LBT IkzlP2FXEgJxmeL49NiPepCl2/XJVFej37yyU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=sR8ynS6dqDZcP7BIK0Qw7JHE5FyGHgJWlrd7MHAyHW3LHukLRR4E/IgSHCk4XC30Me l5isw9YzSxv6X3RWMPMPo4UZZYSvyPGE1gyfWSnvfPYg/ap9oMHrz0rtGVgB0tj4MQPW nwzh+qWkzzFRlVQqUuQWmjRrdn7x6mdyAHk5w= MIME-Version: 1.0 Received: by 10.224.60.133 with SMTP id p5mr8843565qah.331.1286335134791; Tue, 05 Oct 2010 20:18:54 -0700 (PDT) Received: by 10.220.187.194 with HTTP; Tue, 5 Oct 2010 20:18:54 -0700 (PDT) In-Reply-To: <4CABCC67.9070907@freebsd.org> References: <4CAB9212.4010203@freebsd.org> <4CABCC67.9070907@freebsd.org> Date: Wed, 6 Oct 2010 03:18:54 +0000 Message-ID: From: Paul B Mahol To: Julian Elischer Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-net@freebsd.org Subject: Re: ndis: fix ugly code X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2010 03:18:55 -0000 On 10/6/10, Julian Elischer wrote: > On 10/5/10 5:27 PM, Paul B Mahol wrote: >> On 10/5/10, Julian Elischer wrote: >>> On 10/5/10 1:19 PM, Paul B Mahol wrote: >>>> Hi, >>>> >>>> If clang did not complain, I would probbaly never spot it. >>>> >>>> Patch attached. >>> personally I think you could use kproc_kthread_add so that a single >>> NDIS process had three threads. >> Patch attached. Now we have single "ndis" kernel process with own threads. > I don't know how ndis works. Is it possible that each ndis driver > would have it's own process? or would each instance? > I don't even know if it's possible to run two different ndis drivers > in the same kernel. > if that was the case we'd want to have a different name for each one > so you can tell them, > but I just don't know enough about it. Nothing have changed in funcionality. We are just using kernel thread instead of kernel process.