From owner-freebsd-hackers@FreeBSD.ORG Tue Jan 26 21:52:39 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7FC83106566C for ; Tue, 26 Jan 2010 21:52:39 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-ew0-f218.google.com (mail-ew0-f218.google.com [209.85.219.218]) by mx1.freebsd.org (Postfix) with ESMTP id E43F08FC33 for ; Tue, 26 Jan 2010 21:52:37 +0000 (UTC) Received: by ewy10 with SMTP id 10so488676ewy.3 for ; Tue, 26 Jan 2010 13:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=0Eo+JS08/EM3TjjnxVZzOPsiKGpV8Ajd0mNUdj/toT4=; b=CaLkkWm7cnXCGiBusPCOAYAI0ssYwNP0ZKBGC/INuzFrwqk2y0BDJBGPlTMCKu9kK1 O0xddfjUTxuUFOjB0dE+vmjiN/sa+6j2n81xqbzc5tTW5dZc4a+IrOXBjnLPEs8joY9v ChA5l2u66vuzNnGPQR+MlqHvQDuuddwi4+yLE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=YUDZ4Ezcy3p44iDpAtvMX+Ea1OMmi7KxUxNVOWgI+Dk4rNAeFRpN4Sy3IE13mENBVJ o6un4cPcspZy+TKw2g4QHX6A4p5dD3ooptyXcqQ8ULo19eVgWmPEjki+al6ecDRRNe1k MkbhZiXNK/Pes97dh8HY+PeyW6hFIPH4UG+J0= MIME-Version: 1.0 Received: by 10.213.43.81 with SMTP id v17mr2467313ebe.0.1264542755707; Tue, 26 Jan 2010 13:52:35 -0800 (PST) In-Reply-To: <201001151110.29417.jhb@freebsd.org> References: <1bd550a01001080919p20ec1b20t82b3761705cd1ff3@mail.gmail.com> <201001151110.29417.jhb@freebsd.org> Date: Tue, 26 Jan 2010 22:52:35 +0100 Message-ID: <1bd550a01001261352h1ecc22dbh8fd2dcf9c8ac51c5@mail.gmail.com> From: =?ISO-8859-1?Q?Fernando_Apestegu=EDa?= To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] linprocfs dofilesystems X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 21:52:39 -0000 2010/1/15 John Baldwin : > On Friday 08 January 2010 12:19:29 pm Fernando Apestegu=EDa wrote: >> Hi all, >> >> This patch implements the "filesystems" file in the linux proc fs. >> I have used it for some time without seeing any problems. Let me >> know in case this is useful. >> >> Tested against 8.0-RELEASE-p1 > > This patch is not correct. =A0It seems that /proc/filesystems is a list o= f > available filesystems, not a list of mounted filesystems. =A0E.g.: > >> cat /proc/filesystems > nodev =A0 sysfs > nodev =A0 rootfs > nodev =A0 bdev > nodev =A0 proc > nodev =A0 sockfs > nodev =A0 binfmt_misc > nodev =A0 usbfs > nodev =A0 usbdevfs > nodev =A0 futexfs > nodev =A0 tmpfs > nodev =A0 pipefs > nodev =A0 eventpollfs > nodev =A0 devpts > =A0 =A0 =A0 =A0ext2 > nodev =A0 ramfs > nodev =A0 hugetlbfs > =A0 =A0 =A0 =A0iso9660 > nodev =A0 relayfs > nodev =A0 mqueue > =A0 =A0 =A0 =A0ext3 > nodev =A0 rpc_pipefs > nodev =A0 nfs > nodev =A0 nfs4 > nodev =A0 autofs > > To do the same thing in FreeBSD you would need to walk the vfsconf list > instead. =A0However, I'm not sure it is worth it to add this unless there > are apps people commonly use that need it. You are right. I have another patch to do the right thing. However as you pointed out maybe it is not useful after all. Is it possible to delete the PR? Sorry for the noise PS: My current patch does not distinguish between common filesystems and pseudo filesystems, where could I find that info? Cheers > > -- > John Baldwin >