From owner-freebsd-hackers@freebsd.org  Wed Feb 17 17:58:44 2021
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA63054C9FA
 for <freebsd-hackers@mailman.nyi.freebsd.org>;
 Wed, 17 Feb 2021 17:58:44 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DglvS5y7wz4S4j;
 Wed, 17 Feb 2021 17:58:44 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from venus.codepro.be (venus.codepro.be [5.9.86.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mx1.codepro.be", Issuer "R3" (verified OK))
 (Authenticated sender: kp)
 by smtp.freebsd.org (Postfix) with ESMTPSA id A53962D1AA;
 Wed, 17 Feb 2021 17:58:44 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: by venus.codepro.be (Postfix, authenticated sender kp) id 3C5534A013;
 Wed, 17 Feb 2021 18:58:43 +0100 (CET)
From: "Kristof Provost" <kp@FreeBSD.org>
To: "Neel Chauhan" <nc@freebsd.org>
Cc: freebsd-hackers@freebsd.org
Subject: Re: MFCing a src commit if I forgot the MFC tags
Date: Wed, 17 Feb 2021 18:58:42 +0100
X-Mailer: MailMate (1.13.2r5673)
Message-ID: <503F17CD-B7CD-4F37-9422-13D6A79C552C@FreeBSD.org>
In-Reply-To: <7b466cd67933ddef2d4eb9b6bdd466e1@freebsd.org>
References: <7b466cd67933ddef2d4eb9b6bdd466e1@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format=flowed; markup=markdown
Content-Transfer-Encoding: quoted-printable
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Technical discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Feb 2021 17:58:44 -0000

On 17 Feb 2021, at 18:46, Neel Chauhan wrote:
> I have this commit: =

> https://cgit.freebsd.org/src/commit/?id=3Da08cdb6cfb1c84b80b5337d46c574=
b55d0e15c63
>
> This commit enables IPFW NAT to NAT a certain port range on the =

> outside, much like a Carrier Grade NAT setup.
>
> When I committed this, I forgot to add the MFC tags. However, I would =

> like to MFC this commit.
>
> Can I just commit this on my own to stable/12 and stable/1, or is =

> there something special I need to do?
>
MFC tags are indicative, not mandatory. I sometimes end up not MFCing =

things I=E2=80=99d tagged with an =E2=80=98MFC after=E2=80=99 after all.
It=E2=80=99s perfectly okay to MFC things that don=E2=80=99t have a tag. =
(Although =

if it=E2=80=99s not your commit it may be a good idea to ask the author w=
hy it =

wasn=E2=80=99t tagged.)

This commit has been in main long enough to be an MFC candidate, so you =

can merge it to stable/13 and stable/12 at any time.

Best regards,
Kristof