From owner-svn-src-all@FreeBSD.ORG Tue Nov 27 23:29:49 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5CDC1B57 for ; Tue, 27 Nov 2012 23:29:49 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id AF27D8FC19 for ; Tue, 27 Nov 2012 23:29:48 +0000 (UTC) Received: (qmail 37523 invoked from network); 28 Nov 2012 01:01:22 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 28 Nov 2012 01:01:22 -0000 Message-ID: <50B54CE0.6080008@freebsd.org> Date: Wed, 28 Nov 2012 00:29:36 +0100 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: "Robert N. M. Watson" Subject: Re: svn commit: r243627 - head/sys/kern References: <201211272004.qARK4qS8047209@svn.freebsd.org> <50B54180.5020608@freebsd.org> <50B54492.5040100@freebsd.org> <956CE44A-BA0F-4FE4-AA38-F4B90C85ECBA@FreeBSD.org> In-Reply-To: <956CE44A-BA0F-4FE4-AA38-F4B90C85ECBA@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Peter Wemm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2012 23:29:49 -0000 On 28.11.2012 00:05, Robert N. M. Watson wrote: > > On 27 Nov 2012, at 22:54, Andre Oppermann wrote: > >>>>> Andre.. this breaks incoming connections. TCP is immediately reset and never even gets to the >>>>> listener process. You need to back out of fix this urgently please. >>>> >>>> I just found out and fixed it. Sorry for the breakage. >>> >>> I'd like to see a much more thorough use of "Reviewed by:" in socket and TCP-related commits -- this >>> is very sensitive code, and a second pair of eyes is always valuable. Post-commit review is not a >>> substitute. Looking back over similar changes in the socket code over the last two years, I see >>> that almost all have reviewers, so I think it would be reasonable to consider it mandatory for these >>> subsystems at this point. The good news is that we have lots of people with expertise in it. >> >> Good to see you becoming more active again. :-) And yes, >> you have a point there. > > Yes -- this is only about three weeks old, however; for the prior six-twelve months, I've been fairly non-existent in FreeBSD-land due to outside obligations :-). Just saw that I did indeed send you a review request three weeks ago. ;-) At the end of a rather long email though. -- Andre