From owner-freebsd-current@FreeBSD.ORG  Sat Mar  2 18:20:27 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id BE99974D;
 Sat,  2 Mar 2013 18:20:27 +0000 (UTC)
 (envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (chez.mckusick.com
 [IPv6:2001:5a8:4:7e72:4a5b:39ff:fe12:452])
 by mx1.freebsd.org (Postfix) with ESMTP id 74600B39;
 Sat,  2 Mar 2013 18:20:27 +0000 (UTC)
Received: from chez.mckusick.com (localhost [127.0.0.1])
 by chez.mckusick.com (8.14.3/8.14.3) with ESMTP id r22IJWSA041214;
 Sat, 2 Mar 2013 10:19:32 -0800 (PST)
 (envelope-from mckusick@chez.mckusick.com)
Message-Id: <201303021819.r22IJWSA041214@chez.mckusick.com>
To: Sergey Kandaurov <pluknet@freebsd.org>,
 David Wolfskill <david@catwhisker.org>
Subject: Re: [PATCH] Fix sbin/fsdb/fsdbutil.c for r247212 
In-reply-to: <CAE-mSOJGUjwpQC-Nw_ZrpLA_YK_aQBzQSYeKTCVeaMOEbK0XrA@mail.gmail.com> 
Date: Sat, 02 Mar 2013 10:19:32 -0800
From: Kirk McKusick <mckusick@mckusick.com>
X-Spam-Status: No, score=0.0 required=5.0 tests=MISSING_MID, UNPARSEABLE_RELAY
 autolearn=failed version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on chez.mckusick.com
X-Mailman-Approved-At: Sat, 02 Mar 2013 22:04:23 +0000
Cc: current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Mar 2013 18:20:27 -0000

> Date: Sun, 24 Feb 2013 22:41:21 +0300
> Subject: Re: [PATCH] Fix sbin/fsdb/fsdbutil.c for r247212
> From: Sergey Kandaurov <pluknet@freebsd.org>
> To: David Wolfskill <david@catwhisker.org>
> Cc: current@freebsd.org, Kirk McKusick <mckusick@freebsd.org>
> 
> On 24 February 2013 19:25, David Wolfskill <david@catwhisker.org> wrote:
>> On Sun, Feb 24, 2013 at 07:05:34AM -0800, David Wolfskill wrote:
>>> ...hine was:
>>> Simple patch attached; world is still building, but at least it got
>>> through the "make dependencies" phase this time.
>>> ...
>>
>> That was incomplete, as it didn't (also) address the change to
>> getdatablk().
>>
>> The attached patch actually made it through buildworld.
>>
>> Note that it is entirely possible that I erred in specifying
>> "BT_UNKNOWN" for the additional "type" argument.
> 
> Hi David.
> 
> Thank you for the proposed fix. I committed it with r247234.
> I'm not sure regarding BT_UNKNOWN value either. Well..  at least
> it should be not worse that it is now, and it should fix the build.
> I have not found any (regressive) changes in fsdb -d `blocks' output.
> 
> -- 
> wbr,
> pluknet

Sorry, I am bad about keeping up with my mckusick@freebsd.org email.
I do need to watch it right after making commits. I also had no idea
that sbin/fsdb shared code with sbin/fsck_ffs. I really do need to
get back in the habit of buildworlds before doing any commits.

All that said, the changes that you have made are correct. The type
is only used for collecting statistics. So, if you do not know the
type, using DT_UNKNOWN is correct. If there is ever a desire to
collect type-of-I/O statistics in fsdb then that choice will need
to be revisited. But, I doubt that type-of-I/O statistics are ever
likely to be interesting in fsdb.

	Kirk McKusick