From owner-cvs-src@FreeBSD.ORG  Sun Dec  4 21:03:41 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 05DF516A41F;
	Sun,  4 Dec 2005 21:03:41 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E840043D58;
	Sun,  4 Dec 2005 21:03:39 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (localhost [127.0.0.1])
	by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id jB4L3bPt022052;
	Mon, 5 Dec 2005 00:03:37 +0300 (MSK)
	(envelope-from yar@comp.chem.msu.su)
Received: (from yar@localhost)
	by comp.chem.msu.su (8.13.3/8.13.3/Submit) id jB4L3b5m022051;
	Mon, 5 Dec 2005 00:03:37 +0300 (MSK) (envelope-from yar)
Date: Mon, 5 Dec 2005 00:03:36 +0300
From: Yar Tikhiy <yar@FreeBSD.org>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20051204210336.GA18653@comp.chem.msu.su>
References: <200511222224.jAMMOSMJ087945@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200511222224.jAMMOSMJ087945@repoman.freebsd.org>
User-Agent: Mutt/1.5.9i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc/periodic/daily 470.status-named
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Dec 2005 21:03:41 -0000

On Tue, Nov 22, 2005 at 10:24:28PM +0000, Doug Barton wrote:
> dougb       2005-11-22 22:24:28 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/periodic/daily   470.status-named 
>   Log:
>   Update the test for failed zone transfers to reflect BIND 9.3.1 semantics
>   Simplify the shell scripting a bit, and remove a useless grep | sed
>   
>   The problem was pointed out by the PR, and I used part of the solution
>   suggested there, but the semantics changed again for 9.2.x -> 9.3.x.
>   
>   PR:             conf/74228
>   Submitted by:   Jeremy Chadwick <freebsd@jdc.parodius.com>
>   
>   Revision  Changes    Path
>   1.7       +8 -10     src/etc/periodic/daily/470.status-named

Excuse me for this late comment, but using `fgrep -E' looks odd
to me because `fgrep' and `grep -E' are orthogonal and mutually
exclusive.  I mean the following part of the change:

-	    fgrep '^'"$start"'.*named\[[[:digit:]]\+\]: denied [AI]XFR from \[.*\]\.[[:digit:]]\+ for' | \
-	    sed -e 's/.*: denied [AI]XFR from \[\(.*\)\]\.[[:digit:]]* for "\(.*\)".*$/\2 from \1/'
+	    fgrep -E ".*named\[[[:digit:]]+\]: transfer of .*failed .*: REFUSED" |
+	    sed -e "s/.*transfer of \'\(.*\)\/IN\' from \(.*\)#[0-9]*: .*/\1 from \2/" |

In the older version it was just broken as it passed a regexp
to plain fgrep.  Now it should work, but still looks strange.

-- 
Yar