From owner-cvs-all@FreeBSD.ORG Tue May 11 11:55:07 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED25916A502 for ; Tue, 11 May 2004 11:55:07 -0700 (PDT) Received: from tx0.oucs.ox.ac.uk (tx0.oucs.ox.ac.uk [129.67.1.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id D001543D49 for ; Tue, 11 May 2004 11:55:06 -0700 (PDT) (envelope-from colin.percival@wadham.ox.ac.uk) Received: from scan0.oucs.ox.ac.uk ([129.67.1.162] helo=localhost) by tx0.oucs.ox.ac.uk with esmtp (Exim 4.24) id 1BNcPB-0006oy-Eg for cvs-all@FreeBSD.org; Tue, 11 May 2004 19:55:05 +0100 Received: from rx0.oucs.ox.ac.uk ([129.67.1.161]) by localhost (scan0.oucs.ox.ac.uk [129.67.1.162]) (amavisd-new, port 25) with ESMTP id 26059-05 for ; Tue, 11 May 2004 19:55:05 +0100 (BST) Received: from gateway.wadham.ox.ac.uk ([163.1.161.253]) by rx0.oucs.ox.ac.uk with smtp (Exim 4.24) id 1BNcPB-0006om-12 for cvs-all@FreeBSD.org; Tue, 11 May 2004 19:55:05 +0100 Received: (qmail 12978 invoked by uid 1004); 11 May 2004 18:55:05 -0000 Received: from colin.percival@wadham.ox.ac.uk by gateway by uid 71 with qmail-scanner-1.20 (clamscan: 0.67. sweep: 2.18/3.79. Clear:RC:1(163.1.161.131):. Processed in 0.152292 secs); 11 May 2004 18:55:05 -0000 Received: from dhcp1131.wadham.ox.ac.uk (HELO piii600.wadham.ox.ac.uk) (163.1.161.131) by gateway.wadham.ox.ac.uk with SMTP; 11 May 2004 18:55:04 -0000 Message-Id: <6.1.0.6.1.20040511194832.03e5e988@popserver.sfu.ca> X-Sender: cperciva@popserver.sfu.ca (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.1.0.6 Date: Tue, 11 May 2004 19:54:58 +0100 To: obrien@FreeBSD.org From: Colin Percival In-Reply-To: <20040511181554.GA13486@dragon.nuxi.com> References: <20040510115040.0C9B516A53A@hub.freebsd.org> <20040511100208.C75906@root.org> <20040511181554.GA13486@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" cc: Maxime Henrion cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Nate Lawson Subject: Re: cvs commit: src/sys/dev/led led.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2004 18:55:08 -0000 At 19:15 11/05/2004, David O'Brien wrote: >On Tue, May 11, 2004 at 10:02:59AM -0700, Nate Lawson wrote: >> Do we even want __FBSDID in .h files? It doesn't seem to make sense since >> it's not a compilation unit (i.e. no linkage). > >It actually does make sense, as a header's contents does wind up in a .o >eventually :-) And header contents can be the cause of problems as much >as a .c file. There is no problem having multiple __FBSDID in either >a.out or ELF objects. However, there are problems with having a header file's __FBSDID tags end up in a several binaries. Quite apart from the resulting bloat, most changes to header files don't actually result in many binaries being modified; including compilable $Id$ tags in the headers would result in lots of spurious binary changes. This would make me (and anyone who uses FreeBSD Update) very unhappy. Colin Percival