From owner-svn-src-all@FreeBSD.ORG Tue Jun 21 16:07:25 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47AB41065672; Tue, 21 Jun 2011 16:07:25 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 956FC8FC13; Tue, 21 Jun 2011 16:07:24 +0000 (UTC) Received: by vws18 with SMTP id 18so2343895vws.13 for ; Tue, 21 Jun 2011 09:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=mCaN4XP7X/wzi2TdNzoY2SDzy2UIXBQzy9kPMDYwKFQ=; b=BsAsw5cWBdWqJf4OkOoL/B4QBoJXAxXWy3FEkd61xljTUEBIue4Ts7JOX0P86wfjcF +liMeIkoyyeeM3oleL9xKuM9UkN1UEDZUr5RQShRDE26GSXJNz/8ei7mvRM6ey5SKcFu 159pNc3jt/s9d7oU/snA8599vrv2t8d3FSjEQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=C+RvUCg5nWf2diIp21Lja8lwmMuZQYHl2kIhjNp34nkqDIw/2Yo9QV0EJus3GC0XJD i1e06ogvasOvhvRiWrt0RVmzPF+SNZ5vm7lzUiP3hx2kN8bdYkeUu8vGimNZpCK38g8G EbgLKAF3UEusFpzZ3tZWTau+KT7IrBWxSFLNU= MIME-Version: 1.0 Received: by 10.52.98.34 with SMTP id ef2mr5540910vdb.293.1308672443711; Tue, 21 Jun 2011 09:07:23 -0700 (PDT) Received: by 10.52.114.99 with HTTP; Tue, 21 Jun 2011 09:07:23 -0700 (PDT) In-Reply-To: <201106210907.18414.jhb@freebsd.org> References: <201106202259.p5KMxT1h069297@svn.freebsd.org> <201106210907.18414.jhb@freebsd.org> Date: Tue, 21 Jun 2011 09:07:23 -0700 Message-ID: From: Jack Vogel To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jack F Vogel , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223350 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 16:07:25 -0000 LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the older for this. What other globals do you think should be retained? Jack On Tue, Jun 21, 2011 at 6:07 AM, John Baldwin wrote: > On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: > > Author: jfv > > Date: Mon Jun 20 22:59:29 2011 > > New Revision: 223350 > > URL: http://svn.freebsd.org/changeset/base/223350 > > > > Log: > > Eliminate some global tuneables in favor of adapter-specific, > > particular flow control and dma coalesce. Also improve the > > sysctl operation on those too. > > > > Add IPv6 detection in the ioctl code, this was done for > > ixgbe first, carrying that over. > > > > Add resource ability to disable particular adapter. > > > > Add HW TSO capability so vlans can make use of TSO > > The tunables are useful for setting defaults for all interfaces. :( > > I use hw.igb.rx_processing_limit=-1 in loader.conf at work so that we can > ensure that all igb interfaces in a given system have that setting. This > is > more scalable than having to set the right number of entries in > /etc/sysctl.conf.local on different machines, etc, without spamming the > console during boot with warnings about tweaking non-existing sysctls, etc. > > Please consider keeping the tunables where the tunables are used to set > default settings for all adapters from the loader but per-device sysctls > are > used post-boot to provide runtime, per-device settings. > > -- > John Baldwin >