From owner-cvs-all@FreeBSD.ORG Mon Jun 11 20:33:37 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AE90616A46B for ; Mon, 11 Jun 2007 20:33:37 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.180]) by mx1.freebsd.org (Postfix) with ESMTP id 8713813C4AD for ; Mon, 11 Jun 2007 20:33:37 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by wa-out-1112.google.com with SMTP id j37so2471831waf for ; Mon, 11 Jun 2007 13:33:37 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=cyvDjX13vQ/rZceYeQbz249tzopdwzSbUJT1Q/423WSf4b7BvmRgHOQB8ZwopMfu286QPFMvhl9vMIpszVfuh3o95X7WfFt68xqPKFqVvbNRCHbBYXlepfQyV2YOlXo9FzMNkVfD0V81MTBXZ5GuX15NnIHdGVq+k6IgBIbnEM4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=dem4ekcsKn7Fk0FXyxG+oPupX1kaiEBO1ro6CxzeML9NJalW0mcLZwn3iA+z+p05dp2idBhbryIbS6aJV34FzDJX/dEml5FLEYE+xC7b4An4C7Ersa5DAIpKRmH/oDEZqa5hdjtS0etFVyxR6cm6foOgALFSgKZWcEL3QC4OfcY= Received: by 10.114.193.1 with SMTP id q1mr5885659waf.1181594017317; Mon, 11 Jun 2007 13:33:37 -0700 (PDT) Received: by 10.114.126.10 with HTTP; Mon, 11 Jun 2007 13:33:37 -0700 (PDT) Message-ID: <2a41acea0706111333p5349993dg9315bfe8396f78a@mail.gmail.com> Date: Mon, 11 Jun 2007 13:33:37 -0700 From: "Jack Vogel" To: "Sam Leffler" In-Reply-To: <2a41acea0706111330v6a39cf84o495f6acf62ba7ff7@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org> <466DACD6.4040606@errno.com> <2a41acea0706111330v6a39cf84o495f6acf62ba7ff7@mail.gmail.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andre Oppermann , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 20:33:37 -0000 On 6/11/07, Jack Vogel wrote: > On 6/11/07, Sam Leffler wrote: > > Andre Oppermann wrote: > > > andre 2007-06-11 20:08:12 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/net if.h > > > Log: > > > Add IFCAP_LRO flag for drivers to announce their TCP Large Receive Offload > > > capabilities. > > > > > > Revision Changes Path > > > 1.108 +1 -0 src/sys/net/if.h > > > http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108 > > > > > > > > There are many offload capabilities defined that are not well thought > > out. In particular we do not distinguish between ipv4 and ipv6 for > > things like cksum and tso so there's no way to disable individual > > features. The ability to tweak LRO is clearly needed and clearly belong > > as an ifnet capability but unilateraly deciding this is the wrong approach. > > > > Sam > > We do distinguish between TSO4 and TSO6, its just that all the pieces > for 6 arent actually there yet, you are right about the cksum granularity, > but I'm not convinced its needed. You might be right on the need to > fine tune the functionality, but having a big ON/OFF doesnt seem a > bad thing to me. Oh, one other useful tidbit, for Oplin when RSS is enabled you can't do CKSUM anyway, they reuse bits. Jack