From owner-cvs-all@FreeBSD.ORG  Tue Jul 22 06:40:09 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 83F8A37B401; Tue, 22 Jul 2003 06:40:09 -0700 (PDT)
Received: from mailhub.fokus.fraunhofer.de (mailhub.fokus.fraunhofer.de
	[193.174.154.14])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9C26643F3F; Tue, 22 Jul 2003 06:40:07 -0700 (PDT)
	(envelope-from brandt@fokus.fraunhofer.de)
Received: from beagle (beagle [193.175.132.100])h6MDe3v09611;
	Tue, 22 Jul 2003 15:40:03 +0200 (MEST)
Date: Tue, 22 Jul 2003 15:40:03 +0200 (CEST)
From: Harti Brandt <brandt@fokus.fraunhofer.de>
To: Bosko Milekic <bmilekic@technokratis.com>
In-Reply-To: <20030722093652.GE58118@technokratis.com>
Message-ID: <20030722153538.E83041@beagle.fokus.fraunhofer.de>
References: <200307221246.h6MCkVMg081118@repoman.freebsd.org>
 <20030722093652.GE58118@technokratis.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netatm atm_cm.c atm_socket.c atm_subr.c
 src/sys/netatm/ipatm ipatm_load.c src/sys/netatm/sigpvc sigpvc_if.c
 src/sys/netatm/spans spans_arp.c spans_cls.c spans_if.c src/sys/neta
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Hartmut Brandt <harti@FreeBSD.org>
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2003 13:40:10 -0000

On Tue, 22 Jul 2003, Bosko Milekic wrote:

BM>
BM>On Tue, Jul 22, 2003 at 05:46:31AM -0700, Hartmut Brandt wrote:
BM>> harti       2003/07/22 05:46:31 PDT
BM>[...]
BM>>   Also add rudimentary error handling in some places (panic) when a zone
BM>>   cannot be created.
BM>
BM>  This is probably a good move but, FWIW, these are never supposed to
BM>  fail as the UMA zone creation code calls an allocation with M_WAITOK,
BM>  regardless of who or where the caller is.

You are right. Now the handling is at least consistent and things may
change... Looking at the (undocumented) flags parameter of uma_zcreate()
I would think you could specify M_NOWAIT, but alas these flags serve
entirely different purpose (see uma.h). I'll think, I'll keep the panics.

harti
-- 
harti brandt,
http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private
brandt@fokus.fraunhofer.de, harti@freebsd.org