From owner-freebsd-ports@FreeBSD.ORG Sat Jan 17 09:44:50 2015 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8310226A; Sat, 17 Jan 2015 09:44:50 +0000 (UTC) Received: from mail.pingpong.net (mail2.pingpong.net [79.136.116.202]) by mx1.freebsd.org (Postfix) with ESMTP id 5A14F104; Sat, 17 Jan 2015 09:44:46 +0000 (UTC) Received: from [10.0.1.14] (h-85-24-195-48.na.cust.bahnhof.se [85.24.195.48]) by mail.pingpong.net (Postfix) with ESMTPA id 16DD75EBD; Sat, 17 Jan 2015 10:37:52 +0100 (CET) References: <20150115160113.GE98528@ivaldir.etoilebsd.net> <20150117004151.GO98528@ivaldir.etoilebsd.net> In-Reply-To: <20150117004151.GO98528@ivaldir.etoilebsd.net> Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: <171ED59D-E445-4605-B72C-E9ED8A74CA28@pingpong.net> X-Mailer: iPad Mail (9B206) From: Palle Girgensohn Subject: Re: postgresql93 port and libedit Date: Sat, 17 Jan 2015 10:37:49 +0100 To: Baptiste Daroussin Cc: "pgsql@FreeBSD.org" , "freebsd-ports@freebsd.org" , Waitman Gobble X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2015 09:44:50 -0000 17 jan 2015 kl. 01:41 skrev Baptiste Daroussin : > On Thu, Jan 15, 2015 at 08:02:22PM -0800, Waitman Gobble wrote: >> On Thu, Jan 15, 2015 at 8:01 AM, Baptiste Daroussin wr= ote: >>> On Wed, Jan 14, 2015 at 10:27:14PM -0800, Waitman Gobble wrote: >>>> Hi, >>>>=20 >>>> I noticed that postgresql93-client port pulls in readline, which is GPL= v3. >>>> When I get rid of readline in Makefile 'USES' and also change the >>>> bottom of the Makefile in postgresql93-server, >>>>=20 >>>> ... >>>> .include "${.CURDIR}/../postgresql92-server/Makefile" >>>>=20 >>>> CONFIGURE_ARGS+=3D--with-libedit-preferred >>>>=20 >>>>=20 >>>> It builds without readline and links against libedit in base: >>>>=20 >>> except that libedit is not really an alternative as it does not supprot u= nicode >>> (except in head) one solution would be to try linking against the editli= ne port >>> which contains the same fixes as libedit in head and see if it works. >>>=20 >>> Best regards, >>> Bapt >>=20 >> Thanks so much for the feedback. I've considered the options regarding >> my project and I think it's more work to handle end-user devices with >> a pkg repository if I indeed must manage custom ports built using >> customized sources. Distributing the initial appliance isn't the >> problem, i'm working out an update strategy for down the road. >>=20 >=20 > https://people.freebsd.org/~bapt/pglibedit.diff >=20 > This patch works for me and accepts perfectly unicode. >=20 > Can anyone from the postgresql team test, generalize to other postegresql > versions? (please keep it using the port version of libedit). >=20 > Best regards, > Bapt Hi, Looks like a reasonable patch. I have a hard time finding the differences be= tween readine and ilbedit. It aims at 100% API compatibility. How good is li= bedit? If it degrades functionality compared to readline it should really be= an option, but I agree, lesser options are preferred.=20 Palle=