From owner-freebsd-current@FreeBSD.ORG Thu Mar 6 20:34:56 2008 Return-Path: Delivered-To: current@FreeBSD.Org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE1511065670; Thu, 6 Mar 2008 20:34:56 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 239E78FC16; Thu, 6 Mar 2008 20:34:55 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from kobe.laptop (vader.bytemobile-rio.ondsl.gr [83.235.57.37]) (authenticated bits=128) by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id m26KJA8s025623 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 6 Mar 2008 22:19:21 +0200 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id m26KJ5ns011392; Thu, 6 Mar 2008 22:19:05 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id m26KJ5op011391; Thu, 6 Mar 2008 22:19:05 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Thu, 6 Mar 2008 22:19:05 +0200 From: Giorgos Keramidas To: Mike Makonnen Message-ID: <20080306201905.GA11317@kobe.laptop> References: <20080202012707.GA1800@kobe.laptop> <1204809780.885.3.camel@sol> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1204809780.885.3.camel@sol> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.977, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.42, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Spam-Status: No Cc: current@FreeBSD.Org Subject: Re: latest rc.subr breaks etc/rc.d/sendmail X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Mar 2008 20:34:56 -0000 On 2008-03-06 16:23, Mike Makonnen wrote: > On Sat, 2008-02-02 at 03:27 +0200, Giorgos Keramidas wrote: > > Hi Mike, > > Revision 1.80 of src/etc/rc.subr stops Sendmail from starting > > here with: > > > > root@kobe:/root# /etc/rc.d/sendmail start > > Cannot 'start' sendmail. Set sendmail_enable to YES in /etc/rc.conf or use 'onestart' instead of 'start'. > > root@kobe:/root# > > > > My /etc/rc.conf contains: > > > > root@kobe:/root# grep sendmail /etc/rc.conf > > sendmail_enable="NO" > > sendmail_outbound_enable="NO" > > sendmail_submit_enable="YES" > > sendmail_msp_queue_enable="YES" > > root@kobe:/root# > > Can you try the attached patch please? It worked, thanks :) > In the long term I think the sendmail script will have to be broken up > into its constituent parts, but this should fix the problem. Agreed. We should probably consult gshapiro about this, and just do it if there's no objection. AFAIK, /etc/rc.d/sendmail is also used to start alternative MTAs, so we can commit this patch for now, and think about splitting /etc/rc.d/sendmail to something like: src/etc/rc.d/sendmail src/etc/rc.d/sendmail-submit src/etc/rc.d/sendmail-outbound src/etc/rc.d/sendmail-msp-queue One thing to consider before a switch like this is that admins may have installed scripts which assume that /etc/rc.d/sendmail is all they need :/ > Index: etc/rc.d/sendmail > =================================================================== > RCS file: /home/ncvs/src/etc/rc.d/sendmail,v > retrieving revision 1.18 > diff -u -r1.18 sendmail > --- etc/rc.d/sendmail 8 Dec 2007 07:20:22 -0000 1.18 > +++ etc/rc.d/sendmail 21 Feb 2008 07:38:42 -0000 > @@ -72,7 +72,9 @@ > fi > } > > -run_rc_command "$1" > +if checkyesno sendmail_enable; then > + run_rc_command "$1" > +fi > > required_files= > > @@ -90,9 +92,11 @@ > run_rc_command "$1" > fi > > -name="sendmail_clientmqueue" > -rcvar="sendmail_msp_queue_enable" > -start_cmd="${command} ${sendmail_msp_queue_flags}" > -pidfile="${sendmail_mspq_pidfile:-/var/spool/clientmqueue/sm-client.pid}" > -required_files="/etc/mail/submit.cf" > -run_rc_command "$1" > +if checkyesno sendmail_msp_queue_enable; then > + name="sendmail_clientmqueue" > + rcvar="sendmail_msp_queue_enable" > + start_cmd="${command} ${sendmail_msp_queue_flags}" > + pidfile="${sendmail_mspq_pidfile:-/var/spool/clientmqueue/sm-client.pid}" > + required_files="/etc/mail/submit.cf" > + run_rc_command "$1" > +fi