From owner-svn-src-head@FreeBSD.ORG Sat Nov 7 20:52:05 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2A7C106566B for ; Sat, 7 Nov 2009 20:52:05 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 5A2898FC25 for ; Sat, 7 Nov 2009 20:52:05 +0000 (UTC) Received: (qmail 9658 invoked by uid 399); 7 Nov 2009 20:52:04 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 7 Nov 2009 20:52:04 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AF5DDFB.10107@FreeBSD.org> Date: Sat, 07 Nov 2009 12:52:11 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Sam Leffler References: <200911071842.nA7IgsNn060380@svn.freebsd.org> <4AF5C3C7.1020806@freebsd.org> In-Reply-To: <4AF5C3C7.1020806@freebsd.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r199018 - head/sys/dev/wpi X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2009 20:52:06 -0000 Sam Leffler wrote: > The right thing to do is to set wpi_debug to 0 and leave the messages > compiled in. Well as you can see from the diff I did leave the messages in the source so that anyone who wants to enable debugging again can just define WPI_DEBUG at build time to get it. However defining WPI_DEBUG to 0 resulted in the debug messages being printed on the console again so if I'm understanding what you're suggesting correctly it seems that it would require a lot more changes in the code to accomplish. (I did see other examples of what I think you're suggesting in sys/ but this driver doesn't seem to have that support.) If I'm not understanding something or you have a better solution feel free to implement it. My goal was just to get a less noisy console at boot time. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/