From owner-p4-projects@FreeBSD.ORG Mon Jul 9 17:23:28 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id E169016A46E; Mon, 9 Jul 2007 17:23:27 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7E17716A46B for ; Mon, 9 Jul 2007 17:23:27 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id BC46F13C48A for ; Mon, 9 Jul 2007 17:23:26 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l69HNQb5083869 for ; Mon, 9 Jul 2007 17:23:26 GMT (envelope-from cnst@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l69HNQFM083866 for perforce@freebsd.org; Mon, 9 Jul 2007 17:23:26 GMT (envelope-from cnst@FreeBSD.org) Date: Mon, 9 Jul 2007 17:23:26 GMT Message-Id: <200707091723.l69HNQFM083866@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to cnst@FreeBSD.org using -f From: "Constantine A. Murenin" To: Perforce Change Reviews Cc: Subject: PERFORCE change 123216 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2007 17:23:28 -0000 http://perforce.freebsd.org/chv.cgi?CH=123216 Change 123216 by cnst@dale on 2007/07/09 17:23:21 use device_printf where appropriate. Suggested by sam@ and netchild@. Saves about 16 bytes on i386. text data bss dec hex filename 5247 3800 0 9047 2357 lm78.o.orig 5228 3800 0 9028 2344 lm78.o -rw-r--r-- 1 root wheel 29432 Jul 9 13:02 lm78.o.orig -rw-r--r-- 1 root wheel 29416 Jul 9 13:06 lm78.o Affected files ... .. //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78.c#3 edit Differences ... ==== //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78.c#3 (text+ko) ==== @@ -1,4 +1,4 @@ -/* $P4: //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78.c#2 $ */ +/* $P4: //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78.c#3 $ */ /* $FreeBSD$ */ /* $OpenBSD: lm78.c,v 1.18 2007/05/26 22:47:39 cnst Exp $ */ @@ -403,8 +403,7 @@ return; if (sensor_task_register(sc, lm_refresh, 8*60 /* 8 minutes */)) { - printf("%s: unable to register update task\n", - device_get_nameunit(sc->sc_dev)); + device_printf(sc->sc_dev, "unable to register update task\n"); return; }