Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Jul 2007 17:23:26 GMT
From:      "Constantine A. Murenin" <cnst@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 123216 for review
Message-ID:  <200707091723.l69HNQFM083866@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=123216

Change 123216 by cnst@dale on 2007/07/09 17:23:21

	use device_printf where appropriate. Suggested by sam@ and netchild@.
	Saves about 16 bytes on i386.
	
	   text    data     bss     dec     hex filename
	   5247    3800       0    9047    2357 lm78.o.orig
	   5228    3800       0    9028    2344 lm78.o
	
	-rw-r--r--  1 root  wheel  29432 Jul  9 13:02 lm78.o.orig
	-rw-r--r--  1 root  wheel  29416 Jul  9 13:06 lm78.o

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78.c#3 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78.c#3 (text+ko) ====

@@ -1,4 +1,4 @@
-/*	$P4: //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78.c#2 $	*/
+/*	$P4: //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78.c#3 $	*/
 /*	$FreeBSD$	*/
 /*	$OpenBSD: lm78.c,v 1.18 2007/05/26 22:47:39 cnst Exp $	*/
 
@@ -403,8 +403,7 @@
 		return;
 
 	if (sensor_task_register(sc, lm_refresh, 8*60 /* 8 minutes */)) {
-		printf("%s: unable to register update task\n",
-		    device_get_nameunit(sc->sc_dev));
+		device_printf(sc->sc_dev, "unable to register update task\n");
 		return;
 	}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707091723.l69HNQFM083866>