From owner-svn-src-head@freebsd.org  Wed Nov 15 18:47:17 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF74DDE404C;
 Wed, 15 Nov 2017 18:47:17 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A68D57567A;
 Wed, 15 Nov 2017 18:47:17 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id vAFIlGJ2052510;
 Wed, 15 Nov 2017 10:47:16 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id vAFIlGD9052509;
 Wed, 15 Nov 2017 10:47:16 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201711151847.vAFIlGD9052509@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r325860 - head/sbin/newfs
In-Reply-To: <201711151840.vAFIefKV002185@repo.freebsd.org>
To: Ed Maste <emaste@freebsd.org>
Date: Wed, 15 Nov 2017 10:47:16 -0800 (PST)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Nov 2017 18:47:17 -0000

> Author: emaste
> Date: Wed Nov 15 18:40:40 2017
> New Revision: 325860
> URL: https://svnweb.freebsd.org/changeset/base/325860
> 
> Log:
>   newfs: warn if newer than kernel
>   
>   Creating a UFS filesystem with a newfs newer than the running kernel,
>   and then mounting that filesystem, can lead to interesting failures.
>   
>   Add a safety belt to explicitly warn when newfs is newer than the
>   running kernel.

You should probably make the warning if (newer || older) as
either is likely to have interesting side effects, as are
mounting ufs file systems on different versions.

*Sigh*  why did not UFS grow a version number of its own
when things started to change other than UFS1 vs UFS2.


>   Reviewed by:	gjb, jhb, mckusick
>   Sponsored by:	The FreeBSD Foundation
>   Differential Revision:	https://reviews.freebsd.org/D12765
> 
> Modified:
>   head/sbin/newfs/newfs.c
> 
> Modified: head/sbin/newfs/newfs.c
> ==============================================================================
> --- head/sbin/newfs/newfs.c	Wed Nov 15 18:03:31 2017	(r325859)
> +++ head/sbin/newfs/newfs.c	Wed Nov 15 18:40:40 2017	(r325860)
> @@ -398,6 +398,10 @@ main(int argc, char *argv[])
>  		if (pp != NULL)
>  			pp->p_size *= secperblk;
>  	}
> +	if (getosreldate() < __FreeBSD_version) {
> +		warnx("%s is newer than the running kernel and may not be compatible",
> +		    getprogname());
> +	}
>  	mkfs(pp, special);
>  	ufs_disk_close(&disk);
>  	if (!jflag)
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org