From owner-freebsd-multimedia@FreeBSD.ORG Tue Dec 11 18:07:37 2007 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 712D216A418 for ; Tue, 11 Dec 2007 18:07:37 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao102.cox.net (eastrmmtao102.cox.net [68.230.240.8]) by mx1.freebsd.org (Postfix) with ESMTP id 3845A13C47E for ; Tue, 11 Dec 2007 18:07:37 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo01.cox.net ([68.1.16.119]) by eastrmmtao102.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20071211180737.CPGN7592.eastrmmtao102.cox.net@eastrmimpo01.cox.net>; Tue, 11 Dec 2007 13:07:37 -0500 Received: from mezz.mezzweb.com ([24.255.149.218]) by eastrmimpo01.cox.net with bizsmtp id PW6w1Y00N4iy4EG0000000; Tue, 11 Dec 2007 13:06:57 -0500 Date: Tue, 11 Dec 2007 12:12:36 -0600 To: "Jona Joachim" From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 References: <200712060650.lB66o4kF022891@freefall.freebsd.org> <20071207231159.7ec5cc90@spaceman.my.domain> <20071211124248.6acc1382@hcl-club.lu> Content-Transfer-Encoding: Quoted-Printable Message-ID: In-Reply-To: User-Agent: Opera Mail/9.24 (Linux) Cc: freebsd-multimedia@freebsd.org Subject: Re: ports/118458: [UPDATE] multimedia/handbrake X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2007 18:07:37 -0000 On Tue, 11 Dec 2007 11:39:06 -0600, Jeremy Messenger wro= te: > On Tue, 11 Dec 2007 11:27:11 -0600, Jeremy Messenger = > wrote: > >> On Tue, 11 Dec 2007 05:42:48 -0600, Jona Joachim = >> wrote: >> >> >>> I tested it with your latest changes on my system and everything wor= ks >>> as expected, on-the-fly DVD ripping was also fine. >>> >>> However it doesn't build in tinderbox. >>> >>> Here is the whole output: >>> http://www.hcl-club.lu/~jaj/stuff/handbrake-0.9.1.log >>> >>> The main problem is that libvorbis doesn't build because it doesn't >>> find libogg: >>> >>> checking for Ogg... no >>> ... >>> configure: error: must have Ogg installed! >>> >>> (on line 6678) >> >> Umm... I think I see a problem with it. It couldn't find ogg, because= = >> pkg-config does not exist. I have built handbrake and see in the = >> config.log of libvorbis: >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> configure:20133: found /usr/local/bin/pkg-config >> configure:20146: result: /usr/local/bin/pkg-config >> configure:20164: checking for ogg >=3D 1.0 >> configure:20168: result: yes >> configure:20172: checking OGG_CFLAGS >> configure:20175: result: -I/usr/local/include >> configure:20178: checking OGG_LIBS >> configure:20181: result: -L/usr/local/lib -logg >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> Ouch, it built with my system's libogg rather than handbrake's libogg= . = >> It needs to be tweak the PKG_CONFIG_PATH by set it to = >> 'PKG_CONFIG_PATH=3D$CONTRIB/lib/pkgconfig'. But after look inside = >> libvorbis that there has options: >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --with-ogg=3DPFX Prefix where libogg is installed (optional) >> --with-ogg-libraries=3DDIR Directory where libogg library is = >> installed (optional) >> --with-ogg-includes=3DDIR Directory where libogg header files ar= e = >> installed (optional) >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> Let's add '--with-ogg-includes=3D$CONTRIB/include = >> --with-ogg-libraries=3D$CONTRIB/lib' in files/patch-contrib-Jamfile a= fter = >> that '--with-ogg=3D$CONTRIB' to see if it helps in your tinderbox. If= not = >> then we will have to go with PKG_CONFIG_PATH stuff. I couldn't help it, I did it myself and the --with-ogg-*=3D stuff above = = don't work. > Maybe it's best for us to setup PKG_CONFIG_PATH too to avoid create = > other problems. I haven't test it yet, so hopeful it won't cause anoth= er = > problem to set 'PKG_CONFIG_PATH=3D$CONTRIB/lib/pkgconfig' without add = = > ${LOCALBASE}/libdata/pkgconfig. Try to add = > 'CONFIGURE_ENV+=3DPKG_CONFIG_PATH=3D${WRKSRC}/contrib/lib/pkgconfig' i= n = > Makefile. The PKG_CONFIG_PATH method works great. I have modified Makefile to add = = pkg-config in build dependency and add CONFIGURE_ENV line too. The = libvorbis's config.log now looks like this: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D configure:20133: found /usr/local/bin/pkg-config configure:20146: result: /usr/local/bin/pkg-config configure:20164: checking for ogg >=3D 1.0 configure:20168: result: yes configure:20172: checking OGG_CFLAGS configure:20175: result: = -I/usr/home/mezz/commit/handbrake/work/HandBrake/contrib/include configure:20178: checking OGG_LIBS configure:20181: result: = -L/usr/home/mezz/commit/handbrake/work/HandBrake/contrib/lib -logg =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Update: http://people.freebsd.org/~mezz/diff/handbrake.diff Let me know how it works for your tinderbox with this change. Okay, I wi= ll = quit spamming around. :-) Cheers, Mezz > Cheers, > Mezz > >>> The are some other minor problems. >> >> What other minor problems? >> >>> Unfortunately tinderbox always cleans the work folder after it >>> finishes. I don't know how to make it keep it to have a look at what= 's >>> going wrong. >> >> Are you using MC tinderbox? If yes, there has README at about 290 lin= e: >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> Sometimes, the log alone is not sufficient for figuring out >> why a port failed to build. In such cases, one must also see the por= t's >> work directory. To have Tinderbox save this, create an empty file = >> called >> ``.keep'' in the port's directory, and the work directory will be = >> tarred, >> compressed, and copied to ${pb}/wrkdirs/{BUILD} (where {BUILD} is the= >> Build name). >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> I used to have a MC tinderbox, but that system has died some months = >> ago. I haven't buy a cheap system for tinderbox yet. >> >> Cheers, >> Mezz -- = mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org http://wiki.freebsd.org/multimedia - multimedia@FreeBSD.org