From owner-freebsd-stable Fri Mar 22 12:31:50 2002 Delivered-To: freebsd-stable@freebsd.org Received: from damnhippie.dyndns.org (12-253-177-2.client.attbi.com [12.253.177.2]) by hub.freebsd.org (Postfix) with ESMTP id CC83037B400; Fri, 22 Mar 2002 12:31:45 -0800 (PST) Received: from [172.22.42.2] (peace.hippie.lan [172.22.42.2]) by damnhippie.dyndns.org (8.11.6/8.11.6) with ESMTP id g2MKVjU55877; Fri, 22 Mar 2002 13:31:45 -0700 (MST) (envelope-from freebsd@damnhippie.dyndns.org) User-Agent: Microsoft Outlook Express Macintosh Edition - 5.01 (1630) Date: Fri, 22 Mar 2002 13:31:45 -0700 Subject: Re: For Review: sendmail 8.12.2 import into -STABLE From: Ian To: Gregory Neil Shapiro , Message-ID: In-Reply-To: <15513.38875.83457.102683@horsey.gshapiro.net> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > My goal is to commit these patches this weekend or the beginning of next > week depending on the feedback I receive. Positive testing feedback will > push it earlier, negative testing feedback may delay it. Looks good... I pulled a fresh copy of -STABLE into a new directory and used your instructions and patches with it, and everything worked perfectly. (I needed to do it with a new/fresh copy because my working copy of -STABLE had some local hacks to let me build and install libmilter even though it was still marked FFR. I didn't want my hacks to skew the results.) I ran into one small glitch, but I don't think it's your problem, I suspect the sendmail folks are at fault... for some reason in the new libmilter/mfapi.h the #include got moved down a few lines so it's after the #include , causing compile failure on my existing milter code that was developed under 8.11.x. Easily fixed, I just included sys/types.h myself before mfapi.h (although I hate having to do things like that... if my code doesn't use anything directly from types.h I shouldn't have to include it). -- Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message