From owner-cvs-src@FreeBSD.ORG  Sun Feb 24 14:50:30 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3955B16A405
	for <cvs-src@FreeBSD.org>; Sun, 24 Feb 2008 14:50:30 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C61D13C4F0
	for <cvs-src@FreeBSD.org>; Sun, 24 Feb 2008 14:50:29 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: (qmail 91264 invoked from network); 24 Feb 2008 14:05:55 -0000
Received: from localhost (HELO [127.0.0.1]) ([127.0.0.1])
	(envelope-sender <andre@freebsd.org>)
	by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
	for <silby@FreeBSD.org>; 24 Feb 2008 14:05:55 -0000
Message-ID: <47C18436.5060308@freebsd.org>
Date: Sun, 24 Feb 2008 15:50:30 +0100
From: Andre Oppermann <andre@freebsd.org>
User-Agent: Thunderbird 1.5.0.14 (Windows/20071210)
MIME-Version: 1.0
To: Mike Silbersack <silby@FreeBSD.org>
References: <200802240513.m1O5DKBG093031@repoman.freebsd.org>
In-Reply-To: <200802240513.m1O5DKBG093031@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet tcp_var.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Feb 2008 14:50:30 -0000

Mike Silbersack wrote:
> silby       2008-02-24 05:13:20 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/netinet          tcp_var.h 
>   Log:
>   Change FreeBSD 7 so that it returns TCP options in
>   the same order that FreeBSD 6 and before did.  Doug
>   White and the other bloodhounds at ISC discovered that
>   while FreeBSD 7's ordering of options was more efficient,
>   it caused some cable modem routers to ignore the
>   SYN-ACKs ordered in this fashion.

Could you be more specific on which models/firmware choke
on this?  I'd like to document all known broken devices and
share the information with other TCP implementors.  Also I
want to try to contact the vendor and have them fix the issue.

-- 
Andre

>   The placement of sackOK after the timestamp option seems
>   to be the critical difference:
>   
>   FreeBSD 6:
>   <mss 1460,nop,wscale 1,nop,nop,timestamp 3512155768 0,sackOK,eol>
>   
>   FreeBSD 7.0:
>   <mss 1460,nop,wscale 3,sackOK,timestamp 1370692577 0>
>   
>   FreeBSD 7.0 + this change:
>   <mss 1460,nop,wscale 3,nop,nop,timestamp 7371813 0,sackOK,eol>