Date: Mon, 23 Mar 2015 09:24:13 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381955 - head/graphics/gdal Message-ID: <5510220D.3030505@FreeBSD.org> In-Reply-To: <20150323135711.GB27378@ivaldir.etoilebsd.net> References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323135711.GB27378@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i2qFM687HVJe7IiVFg8VAeBVAOW7AhROl Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/23/2015 8:57 AM, Baptiste Daroussin wrote: > On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote: >> On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote: >>> On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wrot= e: >>>> New Revision: 381955 >>>> URL: https://svnweb.freebsd.org/changeset/ports/381955 >>>> QAT: https://qat.redports.org/buildarchive/r381955/ >>>> >>>> Log: >>>> - Use -lpthread instead of -pthread >>> >>> Is -pthread going away anytime soon? I'm a bit worried of more alike= >>> changing one to another; since they're identical right now on FreeBSD= , >>> I'd rather reduce amount of patching, leaving whatever is picked by >>> upstream, unless -lpthread really should be preferred over -pthread >>> for some reason I'm unaware of (and ready to learn about). >>> >>> ./danfe >>> >> >> It's a pointless change. Tijl explains here >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198116#c4 >> >=20 > This is not pointless at all this is a long standing thing that should = be > cleaned out for a while, portmgr already gave long ago some blanket to = some > developers to remove that along with all usage of PTHREAD_LIBS. The rea= son is > that it is confusing for maintainers, as if they take example on some o= f our > existing ports they might be driven in the wrong direction. >=20 > Working in cleaning up those is imho important >=20 > Regards, > Bapt >=20 Reading the responses from David and Tijl I'm still at a loss at how this is useful. From my understanding, and what David said, -pthread is more portable. Reading documentation available from simple searching leads me, as a naive developer, to use -pthread. Especially when looking for Linux documentation. Using either is the same as the other on FreeBSD as well. So why the major change? Removing PTHREAD_LIBS makes sense since it is a needless variable leftover from a more complicated past. But why change -pthread to -lpthread? Why not -lthr since -lpthread is actually an alias to that? --=20 Regards, Bryan Drewery --i2qFM687HVJe7IiVFg8VAeBVAOW7AhROl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVECINAAoJEDXXcbtuRpfPaj4IALQu3dvuUgdO3LJU6c5jq4xm fLRAhdlN9jAYSMc5q7L5uKC4UKYz66Lnn9w2HJjOBFzzBIS+bxt58Pguv0XA2lPo 4Q3a19r3qaFJEVQDiLiUvL8dUd4AATzRlEtR0tvIzLnbUODzLR+Qo9791hWC89Vj B7mbpFL5k+a6+QREVAJtn6ApnIV0vQT37MGjNQOqnpMZ6SBCimKA6U4G9U/Wbbks gt7ggnc71olG0tRE/j09NbNHYk3eYHIZGRfsN66FW+VVJN1asd+fO8k2T6GSH79Z 5Y0IreMZVqXigdwxOD9eJ86ZcZak4PyImSqsD5GqiqbPeF5MQxaAUSWq91FYOmQ= =aeoA -----END PGP SIGNATURE----- --i2qFM687HVJe7IiVFg8VAeBVAOW7AhROl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5510220D.3030505>