From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:14:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5255D16A4CE; Fri, 5 Nov 2004 19:14:53 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 23E8443D5A; Fri, 5 Nov 2004 19:14:53 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id iA5JEpVY078068; Fri, 5 Nov 2004 11:14:51 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id iA5JEpvO078067; Fri, 5 Nov 2004 11:14:51 -0800 (PST) (envelope-from obrien) Date: Fri, 5 Nov 2004 11:14:50 -0800 From: "David O'Brien" To: Ceri Davies , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20041105191450.GB44972@dragon.nuxi.com> References: <200411040128.iA41ShNQ055582@repoman.freebsd.org> <20041104111025.GG57641@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041104111025.GG57641@submonkey.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:14:53 -0000 On Thu, Nov 04, 2004 at 11:10:25AM +0000, Ceri Davies wrote: > This line now gets written to /tmp/exports: > > | @@ -876,7 +876,7 @@ configNFSServer(dialogMenuItem *self) > > | vsystem("echo '#/a -maproot=0 -network 10.0.1.0 -mask 255.255.248.0' >> /etc/exports"); > > | vsystem("echo '#' >> /etc/exports"); > > | vsystem("echo '# You should replace these lines with your actual exported filesystems.' >> /etc/exports"); > > | - vsystem("echo '# Note that BSD\'s export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports"); > > | + vsystem("echo \"# Note that BSD's export syntax is 'host-centric' vs. Sun's 'FS-centric' one.\" >> /tmp/exports"); > > Also, wouldn't it just be easier to open() /etc/exports and write to it > that way? I understand that this isn't how this is done anywhere else > in sysinstall, but why not? That's a good question. I guess JKH had a reason at the time. Given the prickliness of sysinstall, I wouldn't change it without a good amount of thought and testing. -- -- David (obrien@FreeBSD.org)