From owner-cvs-ports@FreeBSD.ORG Mon Jan 16 18:57:18 2012 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BD55106566B; Mon, 16 Jan 2012 18:57:18 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward16.mail.yandex.net (forward16.mail.yandex.net [IPv6:2a02:6b8:0:1402::1]) by mx1.freebsd.org (Postfix) with ESMTP id A6CDB8FC14; Mon, 16 Jan 2012 18:57:17 +0000 (UTC) Received: from smtp16.mail.yandex.net (smtp16.mail.yandex.net [95.108.252.16]) by forward16.mail.yandex.net (Yandex) with ESMTP id B850FD21FEF; Mon, 16 Jan 2012 22:57:15 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1326740235; bh=+BwfpMYCYeW+UBiKGEB4QAtE3yxD4wJIcpeXbzGPhBY=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Lj32KpalAYNDfkFo+Rf9rnhTvar4MP3Wp9H+YX5Y9w4T8LlDOqKxAGp1Kd573DTkF oiETa9lBEkMcOI6dh8YZxLIr8HLPsBB/wGtWymLRzqEKu8Xjt5abIqLSRd2cMuFmQn 1CM3Kygo5Pn5k2jysCse5JTMY23nqYIUdfWobv1c= Received: from smtp16.mail.yandex.net (localhost [127.0.0.1]) by smtp16.mail.yandex.net (Yandex) with ESMTP id 63AE46A02F6; Mon, 16 Jan 2012 22:57:15 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1326740235; bh=+BwfpMYCYeW+UBiKGEB4QAtE3yxD4wJIcpeXbzGPhBY=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Lj32KpalAYNDfkFo+Rf9rnhTvar4MP3Wp9H+YX5Y9w4T8LlDOqKxAGp1Kd573DTkF oiETa9lBEkMcOI6dh8YZxLIr8HLPsBB/wGtWymLRzqEKu8Xjt5abIqLSRd2cMuFmQn 1CM3Kygo5Pn5k2jysCse5JTMY23nqYIUdfWobv1c= Received: from unknown (unknown [178.76.224.133]) by smtp16.mail.yandex.net (nwsmtp/Yandex) with ESMTP id vE1G8ZoY-vF1SWlls; Mon, 16 Jan 2012 22:57:15 +0400 X-Yandex-Spam: 1 Message-ID: <4F1472E7.3010309@yandex.ru> Date: Mon, 16 Jan 2012 22:56:39 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: Max Brazhnikov References: <201201130338.q0D3cMgJ018062@repoman.freebsd.org> <201201161838.12941.makc@freebsd.org> In-Reply-To: <201201161838.12941.makc@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@freebsd.org, Veniamin Gvozdikov , Axel Gonzalez , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/audio/clementine-player Makefile ports/audio/clementine-player/files patch-src-devices-cddadevice.h patch-src-devices-cddalister.cpp X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 18:57:18 -0000 Max Brazhnikov wrote on 16.01.2012 22:38: > On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote: >> rm 2012-01-13 03:38:22 UTC >> >> FreeBSD ports repository >> >> Modified files: >> audio/clementine-player Makefile >> Added files: >> audio/clementine-player/files patch-src-devices-cddadevice.h >> patch-src-devices-cddalister.cpp >> Log: >> - let it build with stock gcc >> - optionify ipod and mtp support (default on) > > This type of `port optionification' leads to a nasty problem of hidden > dependencies when options are unchecked, but corresponding libraries are > presented. Please consider to commit the patch, which makes optional support > really optional. > > Max You are right, thank you. Veniamin, do you have any objections if this patch will be committed? -- Regards, Ruslan Tinderboxing kills... the drives.