From owner-freebsd-arch@freebsd.org Tue Jul 3 17:56:31 2018 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBBAD10380F7 for ; Tue, 3 Jul 2018 17:56:31 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 666078EC43 for ; Tue, 3 Jul 2018 17:56:31 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: by mailman.ysv.freebsd.org (Postfix) id 2252110380F6; Tue, 3 Jul 2018 17:56:31 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E4FE10380F5 for ; Tue, 3 Jul 2018 17:56:31 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6129B8EC41; Tue, 3 Jul 2018 17:56:29 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w63HuMH3039272; Tue, 3 Jul 2018 10:56:22 -0700 (PDT) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w63HuM2c039271; Tue, 3 Jul 2018 10:56:22 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201807031756.w63HuM2c039271@pdx.rh.CN85.dnsmgr.net> Subject: Re: xstr, mkstr In-Reply-To: To: Warner Losh Date: Tue, 3 Jul 2018 10:56:22 -0700 (PDT) CC: John Baldwin , Eitan Adler , "freebsd-arch@freebsd.org" X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 17:56:32 -0000 [ Charset UTF-8 unsupported, converting... ] > On Tue, Jul 3, 2018, 11:41 AM Rodney W. Grimes < > freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > On 7/3/18 8:26 AM, Warner Losh wrote: > > > >> "As far as I can tell" needs to be a bit stronger, > > > >> > > > >> Agreed. But before doing work we should first make sure that the work > > > >> will be productive. > > > >> > > > > > > > > Xstr and most are best thought of as a final pass of the old pcc > > compiler. > > > > This functionality moved into gcc before the egcs split back in the > > 90s. > > > > The compiler has done this work for two decades now. Nobody uses it, or > > > > needs it today. > > > > > > > > Unlike tip or cu, nobody at all uses these. > > > > > > Agreed, these tools are quite obscure and I don't think _FreeBSD_ has > > ever > > > used them. > > > > I thought someone already pointed out places in the src tree > > that had references to them, though they may > > > > You removed the SHAREDSTRINGS support in r3493 back in 1994. It's been > unused since then. There are comments that suggest it never worked in > FreeBSD, but that may be 2.0 and newer only. Removed it, not commented it out. Someone else on this thread made statement that stuff is refering to these tools, that could not been what I removed in r3493. I do see that some of what I removed in r3493 is now back as bmake has moved to contrib/ and these strings are now there: ./contrib/bmake/mk/prog.mk:.if defined(SHAREDSTRINGS) ./contrib/bmake/mk/README:SHAREDSTRINGS If defined, a new .c.o rule is used that results in shared Those are parts that I totally removed from share/mk/{bsd.README,bsd.prog.mk} in r3493. The only note I see about "never worked" is that prog.mk stuff is suppose to have issues with Parallel make, thats in the contrib/bmake/mk/README. Where do you have a reference to never worked in FreeBSD? -- Rod Grimes rgrimes@freebsd.org