Date: Sat, 17 Mar 2001 11:25:04 -0800 (PST) From: Matt Dillon <dillon@earth.backplane.com> To: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> Cc: jhb@FreeBSD.ORG (John Baldwin), arch@FreeBSD.ORG Subject: Re: Proposal for the CPU interrupt API Message-ID: <200103171925.f2HJP4x95161@earth.backplane.com> References: <200103170422.UAA55781@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
:and by otherwise I included comments in code. Take this one for example:
:>From sys/i386/isa/if_sr.c
: /*
: * XXX Disable all interrupts for now. I think if you are using the
: * dmac you don't use these interrupts.
: */
: SRC_PUT8(hc->sca_base, msci->ie0, 0);
: SRC_PUT8(hc->sca_base, msci->ie1, 0x0C);
:
:writting 0x0C to msci->ie1 does NOT disable all interrupts!!!
Well, those XXX's seem to indicate that the author wasn't so sure about
what he was doing either. Quite a useful comment, I think!
% fgrep XXX vm/* | wc -l
108
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103171925.f2HJP4x95161>