From owner-cvs-all  Mon Sep  2 14:26: 6 2002
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 931)
	id 70B9437B400; Mon,  2 Sep 2002 14:26:00 -0700 (PDT)
Date: Mon, 2 Sep 2002 14:26:00 -0700
From: Juli Mallett <jmallett@FreeBSD.org>
To: Brooks Davis <brooks@one-eyed-alien.net>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys libkern.h src/sys/conf files
Message-ID: <20020902142600.B61674@FreeBSD.org>
References: <200209022016.g82KGMtv027847@freefall.freebsd.org> <20020902132423.B15010@Odin.AC.HMC.Edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20020902132423.B15010@Odin.AC.HMC.Edu>; from brooks@one-eyed-alien.net on Mon, Sep 02, 2002 at 01:24:23PM -0700
Organisation: The FreeBSD Project <http://FreeBSD.org>
X-Alternate-Addresses: <jmallett@NewGold.NET>, <jmallett@xMach.org>, <juli@jerkcity.com>, <flata@toxic.magnesium.net>, <jmallett@OpenDarwin.org>
X-Towel: Yes
X-LiveJournal: flata, jmallett
X-Negacore: Yes
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

* De: Brooks Davis <brooks@one-eyed-alien.net> [ Data: 2002-09-02 ]
	[ Subjecte: Re: cvs commit: src/sys/sys libkern.h src/sys/conf files ]
> On Mon, Sep 02, 2002 at 01:16:22PM -0700, Brooks Davis wrote:
> > brooks      2002/09/02 13:16:22 PDT
> > 
> >   Modified files:
> >     sys/sys              libkern.h 
> >     sys/conf             files 
> >   Log:
> >   Hook up libkern/strlcpy.c and libkern/strlcat.c after repocopy.
> 
> Intrested parties should start attacking uses of strncat and strncpy.
> All uses of strncat in the kernel and most uses of strncpy are either
> wrong or hard to verify and should be converted to strl*.  We should be
> able to eliminate strncat fairly easily.  strncpy is a bit harder and may
> be used correctly for fixed width, non-NUL-terminated fields so I
> suspect we'll be keeping it around.

Why?  If they're not NUL terminated, use memcpy.
-- 
Juli Mallett <jmallett@FreeBSD.org>       | FreeBSD: The Power To Serve
Will break world for fulltime employment. | finger jmallett@FreeBSD.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message