From owner-freebsd-testing@FreeBSD.ORG Tue Jan 21 23:56:13 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8EDEB237; Tue, 21 Jan 2014 23:56:13 +0000 (UTC) Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5329916E7; Tue, 21 Jan 2014 23:56:13 +0000 (UTC) Received: by mail-pa0-f47.google.com with SMTP id kp14so9086986pab.34 for ; Tue, 21 Jan 2014 15:56:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=cxqtVQc40EyxsN9fr6zNu3t8uCgj2fPXfFqUoQk/UTM=; b=hk5YJLbG3+fi84tMKJfFZWpvOTrOPSnJRZVCC/B03zEpcPJx0oioC3UQEmpzCb7rJD GRNKqIiDZfxVkhAWnUjcyZgT2fMaxwQ4yxWoJc2VvSBVVcjcX2jocj8sthQEtBOSnFlH R7lshMVhpOJVKysqBtcPk+b0mUQqPbojcr0SSEnEODaVLKpN/dHI8v4q8dCuECZaOmFu AHrpuglfGkZKBMr59KCBteSWKyaesZ6VYOCSLTlTEygeuvILZvsbISQMVI2Spg7s4Him xmeDoONIXdLdDQjeqXvDOE1qV7g3VRFpMvcev9oiB2Jh4ZCVel6gcbhTKIY5gUdq0c9z ZccA== X-Received: by 10.69.1.104 with SMTP id bf8mr27672042pbd.75.1390348572865; Tue, 21 Jan 2014 15:56:12 -0800 (PST) Received: from [10.0.2.128] ([64.14.143.130]) by mx.google.com with ESMTPSA id yd4sm16041597pbc.13.2014.01.21.15.56.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Jan 2014 15:56:11 -0800 (PST) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: X-Mailer: iPhone Mail (11B554a) From: Garrett Cooper Subject: Re: PATCH: add ATF tests in sys Date: Tue, 21 Jan 2014 15:56:10 -0800 To: Alan Somers Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 23:56:13 -0000 > On Jan 21, 2014, at 14:45, Alan Somers wrote: >=20 > I rewrote the unix seqpacket tests in ATF. The hard part is adding > them to the build. The linked patch adds them in the directory > sys/kern/tests and builds them as part of buildworld, not buildkernel. > They get installed to /usr/tests/sys/kern, but the intermediate > objects are stored in /usr/obj/sys/kern/tests. That means that you > can't have different tests associated with different kernel configs. > I think that this is desirable, because you wouldn't be able to > install tests for different kernel configs anyway, given our chosen > layout of /usr/tests. >=20 > Please comment on the parts of this patch that deal with Makefiles. > Is this the appropriate way to add sys tests to the build? Shouldn't > I be building them in buildkernel instead of buildworld? I couldn't > find a good way to do that. I bypassed that for simplicity and placed the tests in tests/sys/kern/... et= c. Shoehorning things into our overly complex kernel build system just seems= like a really bad idea... Just make it load as a driver, loadable, and depe= ndent on kern.features to run..? Cheers! -Garrett=