From owner-svn-src-all@FreeBSD.ORG Thu Jun 10 11:14:29 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98BED1065677; Thu, 10 Jun 2010 11:14:29 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail08.syd.optusnet.com.au (mail08.syd.optusnet.com.au [211.29.132.189]) by mx1.freebsd.org (Postfix) with ESMTP id 149098FC08; Thu, 10 Jun 2010 11:14:28 +0000 (UTC) Received: from c122-106-175-69.carlnfd1.nsw.optusnet.com.au (c122-106-175-69.carlnfd1.nsw.optusnet.com.au [122.106.175.69]) by mail08.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o5ABEPnl018348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Jun 2010 21:14:27 +1000 Date: Thu, 10 Jun 2010 21:14:24 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: John Baldwin In-Reply-To: <201006081446.09423.jhb@freebsd.org> Message-ID: <20100610205617.Y33786@delplex.bde.org> References: <201006081804.o58I473g073875@svn.freebsd.org> <201006081446.09423.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r208921 - in head/sys: amd64/amd64 conf i386/i386 x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2010 11:14:29 -0000 On Tue, 8 Jun 2010, John Baldwin wrote: > On Tuesday 08 June 2010 2:04:07 pm John Baldwin wrote: >> Log: >> Move the machine check support code to the x86 tree since it is identical >> on i386 and amd64. >> >> Requested by: alc > > It would be nice to consolidate as that is identical on both > platforms, but that moving to x86/include is trickier as the header needs to > be available in userland, probably as still. > would work ok (i.e. in /usr/include/x86/mca.h), but that makes things trickier > in the kernel as the file should really live in sys/x86/include, not sys/x86 > directly. Having x86/include would defeat . However, is only good for MD implentations of MI interfaces (things like PAGE_SIZE and va_arg()), so mca.h, like many other headers now there, should never have been in . mca.h is very MD and currently only exists for amd64, i386, ia64 and pc98. Applications that know that there is such a file can also know where it is. It should be somewhere like for amd64, i386 and pc98. This is mainly for userland. In the kernel, the natural place for most arch-specific headers is in the arch/arch subdir, not arch/include where they are now. That would be sys/x86/x86 here. There seems to be no reason for the arch/include subdir to exist for pseudo-arches like x86. It would just be a little easier to export only the headers in it if the headers are separate. Bruce