Date: Thu, 20 Mar 2008 11:00:48 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Doug Rabson <dfr@rabson.org> Cc: cvs-src@FreeBSD.org, Doug Rabson <dfr@FreeBSD.org>, Alfred Perlstein <alfred@freebsd.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsserver nfs_srvsock.c Message-ID: <20080320105941.H38241@fledge.watson.org> In-Reply-To: <F042E351-95A3-4C9A-92AF-878CB0F93EBE@rabson.org> References: <200803191233.m2JCXPRp070753@repoman.freebsd.org> <20080320025645.GI67856@elvis.mu.org> <F042E351-95A3-4C9A-92AF-878CB0F93EBE@rabson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 20 Mar 2008, Doug Rabson wrote: >> This function should have a WITNESS check at the top of it. >> >> Can you add it? If not I will unless you see a problem with it. > > The various WITNESS_* macros appear to be undocumented and I'm not sure what > they do. Perhaps it would be best if you added something. I usually copy and paste it from another use, such as the sleep checks for the MAC Framework. When I do that, I often think to myself: wouldn't it be nice if we had a simple WITNESS_MAYSLEEP() macro to say "this code path may sleep, just do whateve ryou're going to do". Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080320105941.H38241>