From owner-freebsd-hackers Sun Feb 2 19:27:37 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id TAA04683 for hackers-outgoing; Sun, 2 Feb 1997 19:27:37 -0800 (PST) Received: from labs.usn.blaze.net.au (labs.usn.blaze.net.au [203.17.53.30]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id TAA04665; Sun, 2 Feb 1997 19:27:29 -0800 (PST) Received: (from davidn@localhost) by labs.usn.blaze.net.au (8.8.5/8.8.5) id OAA15793; Mon, 3 Feb 1997 14:27:17 +1100 (EST) Message-ID: <19970203142717.VR58445@usn.blaze.net.au> Date: Mon, 3 Feb 1997 14:27:17 +1100 From: davidn@unique.usn.blaze.net.au (David Nugent) To: obrien@NUXI.com (David O'Brien) Cc: freebsd-ports@FreeBSD.ORG (FreeBSD ports list), hackers@FreeBSD.ORG Subject: Re: conditionally including References: <199701280143.RAA06503@freefall.freebsd.org> <19970202135048.PN07710@dragon.nuxi.com> X-Mailer: Mutt 0.59.1 Mime-Version: 1.0 In-Reply-To: <19970202135048.PN07710@dragon.nuxi.com>; from David O'Brien on Feb 2, 1997 13:50:48 -0800 Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk David O'Brien writes: > Sorry to have to bring this back to light... > I was under the impression that we had agreed that > "#if (defined(__unix__) || defined(unix))" was the best way to > conditionally include . However, this email from Chuck, > implies that this is a Bad Thing. ~ > > That test is completely bogus, cause it passes for all sysv systems, > > which _don't_ have sys/param.h. It's a completely useless test, and > > someone justified it by saying that "most systems have a sys/param.h > > anyhow". I said exactly this some weeks back and was told I was wrong, contrary to my own experience of many years working with sysv r3's. Oh well. :-) svr4 apparently does have it, but not sysv before that. Most if not all of those do predefine unix or __unix__. Regards, David Nugent - Unique Computing Pty Ltd - Melbourne, Australia Voice +61-3-9791-9547 Data/BBS +61-3-9792-3507 3:632/348@fidonet davidn@freebsd.org davidn@blaze.net.au http://www.blaze.net.au/~davidn/