From owner-freebsd-current@FreeBSD.ORG Tue May 22 20:13:02 2007 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 88E9D16A501; Tue, 22 May 2007 20:13:02 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198]) by mx1.freebsd.org (Postfix) with ESMTP id 2619E13C455; Tue, 22 May 2007 20:13:01 +0000 (UTC) (envelope-from marcus@FreeBSD.org) X-TACSUNS: Virus Scanned Received: from rooster.cisco.com (localhost [127.0.0.1]) by av-tac-rtp.cisco.com (8.11.7p3+Sun/8.11.7) with ESMTP id l4MKD1f21483; Tue, 22 May 2007 16:13:01 -0400 (EDT) Received: from [64.102.193.121] (dhcp-64-102-193-121.cisco.com [64.102.193.121]) by rooster.cisco.com (8.11.7p3+Sun/8.11.7) with ESMTP id l4MKD0q15021; Tue, 22 May 2007 16:13:00 -0400 (EDT) Message-ID: <46534EE2.3090107@FreeBSD.org> Date: Tue, 22 May 2007 16:13:22 -0400 From: Joe Marcus Clarke Organization: FreeBSD, Inc. User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <46534301.10005@FreeBSD.org> <864pm4zkre.fsf@dwp.des.no> In-Reply-To: <864pm4zkre.fsf@dwp.des.no> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: pjd@FreeBSD.org, "current@freebsd.org" Subject: Re: [Fwd: Serious problem with mount(8)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 20:13:02 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dag-Erling Smørgrav wrote: > Joe Marcus Clarke writes: >> I really don't know why I didn't notice this before, but when mount was >> converted to use the pidfile(3) API three months ago, the behavior of >> mount(8) changed with regard to restarting mountd. A pidfile client >> cannot use pidfile_open(3) as this will truncate the pidfile. The >> result is that mount reads in a PID of 0, and when it tries to send a >> SIGHUP to this PID, it kills itself. Consequently, this is breaking the >> ports Tinderbox. >> >> I suppose we could revert to the previous behavior, but use flopen() to >> test if the file is actually locked. Maybe something like this: >> >> http://www.marcuscom.com/downloads/mount.c.diff > > Better yet, extend the pidfile API with a function which reads the > contents of a PID file and also checks whether it's locked. I'd be happy to do this. Is my approach with this code sound (i.e. can I simply port this to pidfile(3)), or should I take another approach? Thanks. Joe - -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGU07ib2iPiv4Uz4cRAro0AKCQp9xjvvozdAZnV/AKkAG+f28O2QCfUFtn Qh7BiapUrg+rRccFb9GQ0TA= =aers -----END PGP SIGNATURE-----