Date: Mon, 16 Feb 2015 21:13:41 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197747] ports-mgmt/portlint : request to warn on patches that don't have UTC in "---" line Message-ID: <bug-197747-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197747 Bug ID: 197747 Summary: ports-mgmt/portlint : request to warn on patches that don't have UTC in "---" line Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: marino@FreeBSD.org Assignee: marcus@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) It is highly desirable that patches are created with "make makepatch" which results in headers like this: --- lib/krb5/ccache/cc_file.c.orig 2014-10-15 23:55:10 UTC +++ lib/krb5/ccache/cc_file.c @@ -136,6 +136,7 @@ get_size(krb5_context context, krb5_ccac Unfortunately, a lot of people still use diff, even reverting the "good" format above, resulting in something like this: --- lib/krb5/ccache/cc_file.c.orig 2014-10-15 16:55:10.000000000 -0700 +++ lib/krb5/ccache/cc_file.c 2015-02-12 13:00:31.967166267 -0800 @@ -136,6 +136,7 @@ Notice the desired "-p" option is lost as well. I think it would be a good idea to check the "--- " line of each patch to make sure it ends in "UTC" and give an appropriate warning and recommendation to use "make makepatch" instead. Since there can be more than one "--- " line per patch, each matching line should be checked IMO. --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer marcus@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197747-13>