From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Feb 16 21:13:42 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 01362460 for ; Mon, 16 Feb 2015 21:13:41 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C008E129 for ; Mon, 16 Feb 2015 21:13:41 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1GLDfQ7061484 for ; Mon, 16 Feb 2015 21:13:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197747] ports-mgmt/portlint : request to warn on patches that don't have UTC in "---" line Date: Mon, 16 Feb 2015 21:13:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: marino@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: marcus@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 21:13:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197747 Bug ID: 197747 Summary: ports-mgmt/portlint : request to warn on patches that don't have UTC in "---" line Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: marino@FreeBSD.org Assignee: marcus@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) It is highly desirable that patches are created with "make makepatch" which results in headers like this: --- lib/krb5/ccache/cc_file.c.orig 2014-10-15 23:55:10 UTC +++ lib/krb5/ccache/cc_file.c @@ -136,6 +136,7 @@ get_size(krb5_context context, krb5_ccac Unfortunately, a lot of people still use diff, even reverting the "good" format above, resulting in something like this: --- lib/krb5/ccache/cc_file.c.orig 2014-10-15 16:55:10.000000000 -0700 +++ lib/krb5/ccache/cc_file.c 2015-02-12 13:00:31.967166267 -0800 @@ -136,6 +136,7 @@ Notice the desired "-p" option is lost as well. I think it would be a good idea to check the "--- " line of each patch to make sure it ends in "UTC" and give an appropriate warning and recommendation to use "make makepatch" instead. Since there can be more than one "--- " line per patch, each matching line should be checked IMO. --- Comment #1 from Bugzilla Automation --- Auto-assigned to maintainer marcus@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.