From owner-svn-ports-all@FreeBSD.ORG Sat Jun 21 07:13:24 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DDA40942 for ; Sat, 21 Jun 2014 07:13:23 +0000 (UTC) Received: from mail-qc0-x22d.google.com (mail-qc0-x22d.google.com [IPv6:2607:f8b0:400d:c01::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9973B2816 for ; Sat, 21 Jun 2014 07:13:23 +0000 (UTC) Received: by mail-qc0-f173.google.com with SMTP id l6so4281445qcy.4 for ; Sat, 21 Jun 2014 00:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ps7yDjiM86I8eGFjtMypVy70icW9kpYEHmVLq/frl3s=; b=NET3UJtNYhQ6fYOtKqnBvsj+dcJlzQsFHOtJQg2nZ0H+2pzlDMmmpWLg8HzPi06QmH Snz+dp+AB7TyRqzkj56qYJiNhVEIpqtby+2am+h4NqFwq5F6PdjZUWORYekDdmYf9j8m KneoJbIps42q+fLRTAPE/coOgIm5BfL5WGOCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=ps7yDjiM86I8eGFjtMypVy70icW9kpYEHmVLq/frl3s=; b=SlovqQBHesEz0fNp3s6z8qK3IicVTyfEHfzkr99bQ3hRyVDxgXyPKtcv/tT0E1wvxi 9M961ST3wO3RxLtzzuixx+cT7QGlcs1cqRN8QuPgVVRsc7V+BIuIetWT8nx18yKxOup9 wemrfHF2RmIdq4EbG9pmIgNBFVN5zEcZKniW5mxz4fhmffd6KnO8deFMoOd96Y4B9Yn5 fxucFCuv5aDGA5g+nwcA6vHaC4M2Phiw1ImMliTlW4czTR+436m7vUr/303dHYD34bKk 6I2gIo4lDrX4PG2OtTQdWAwRLw7UagZOGOLJTUGqwHDmour2yC3XM/YyQ9/qqJ5R3AlS WQbA== X-Gm-Message-State: ALoCoQmq/Y1aTQeCr5WHwHCdB0BKfCcn923TUZxtUefiibPOtPvwNB9kmrOAKKyNgOMDKKBY/v/N X-Received: by 10.224.7.6 with SMTP id b6mr12201525qab.45.1403334802595; Sat, 21 Jun 2014 00:13:22 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.222.131 with HTTP; Sat, 21 Jun 2014 00:12:52 -0700 (PDT) In-Reply-To: <53A52BE1.3010706@gmx.de> References: <201406210639.s5L6dWAE096222@svn.freebsd.org> <53A52BE1.3010706@gmx.de> From: Eitan Adler Date: Sat, 21 Jun 2014 00:12:52 -0700 X-Google-Sender-Auth: i509ob01NHWQ0cGFv8fEIwbrvSo Message-ID: Subject: Re: svn commit: r358666 - head/Mk To: olli hauer Content-Type: text/plain; charset=UTF-8 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jun 2014 07:13:24 -0000 On 20 June 2014 23:53, olli hauer wrote: > On 2014-06-21 08:39, Eitan Adler wrote:> Author: eadler >> Date: Sat Jun 21 06:39:32 2014 >> New Revision: 358666 >> URL: http://svnweb.freebsd.org/changeset/ports/358666 >> QAT: https://qat.redports.org/buildarchive/r358666/ >> >> Log: >> Expand upon option descriptions whose only text are 'option support'. Such >> descriptions provide no value for the user and should be expanded upon. >> >> While here make one description fit in space limit >> >> Reviewed by: marino >> >> Modified: >> head/Mk/bsd.options.desc.mk >> >> Modified: head/Mk/bsd.options.desc.mk >> ============================================================================== >> --- head/Mk/bsd.options.desc.mk Sat Jun 21 06:21:14 2014 (r358665) >> +++ head/Mk/bsd.options.desc.mk Sat Jun 21 06:39:32 2014 (r358666) > >> -LDAP_DESC?= LDAP support >> +LCMS2_DESC?= Little CMS 2.x support >> +LDAP_DESC?= LDAP authentication support >> LDAPS_DESC?= LDAPS support > > > Why the change for LDAP? The same reason for all of them: the format "OPTION_DESC?= OPTION support" provides no value to the user. The option description should provide additional context beyond the name. If the option is overloaded it should be split apart. > The old DESC was about the protocol where the new one suggest a functionality. This was based on a quick grep-and-check of the relevent ports. It was not exhaustive. Maintainers that dislike the current text can override it locally in their port. > LDAP can be used as simple database for a dozen of different things then authentication. Feel free to suggest (or just commit) alternatives. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams