From owner-freebsd-testing@freebsd.org Mon Aug 29 17:32:06 2016 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8226BBC73A6 for ; Mon, 29 Aug 2016 17:32:06 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-qk0-x232.google.com (mail-qk0-x232.google.com [IPv6:2607:f8b0:400d:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 35F0CD46 for ; Mon, 29 Aug 2016 17:32:06 +0000 (UTC) (envelope-from julio@meroh.net) Received: by mail-qk0-x232.google.com with SMTP id v123so145108338qkh.2 for ; Mon, 29 Aug 2016 10:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meroh.net; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FStPkHwzuodzVhbTjAXxxgdmz+V/u41tHbw2JtaDilo=; b=EpEyMkT4/HP/OPyFSVPfQUEBkMzKxxY0TkxEXJGQJu42sTXDATz6boe9bdZLeVE/DL TaYvg/2qscSCzJlGu1DfuK0o7/ZrigPW9nSRmaxuE9NWUjDrr9eVwZJC54NqrPbC00L1 b17LV4KTJCvlIMaRy21a7XURzRX5Lchid+3VhEbWcvVef/dwbHAVZQmCQv7CCDtq6jLU KCjrdfp4/xtVNbGHzCn5LanY8fnsge/F+mw2ltjTfJN/igL77s/t1BpnNgVEzQH9zrEr F0bY5gs+CTiXziAwujNV0axx0XPDH1licxRUwmpVijf3D6tdC+Z/bJPDGI/uZY1obUxl z3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FStPkHwzuodzVhbTjAXxxgdmz+V/u41tHbw2JtaDilo=; b=m4zCOoiV7rCD3JAJlJjuZk0JmhTq8GKkYJEOWjJXO4h/PzbT47CbtytkjszxfusnrA lPg4ZLM989f6lSio4R4HcQOpAweMDkHjEmxzoL4xrceen6cGDZwdv/oBKIPLjCnGzc86 27LMaDLkMGwTe3xjaePIv5epNN0IWK7e7QTfY7VJxCmrxwCbWNvThs7N0tYe8OWo+TGc c+xIITs6dZ6XuD06V2GWiei1g5QcsgIiUJVI0PeVkS3ttdK/KNCG5H3JT5PzBUKU+1xG 9WLq5EfZdAiX5DKWhBux6xucdHfHJASFmJOVwavrRTn8HVsbcbJcBf7La+szRiXgoRWT ORvg== X-Gm-Message-State: AE9vXwPVIPZXzacTqhYpYMwFzYMfURIMiO2enYBZ9C1NC6GDoltM6QDN+JOYhEmAobNASFAg/Zbq6HYRwRKT+w== X-Received: by 10.55.212.83 with SMTP id l80mr20569325qki.179.1472491925331; Mon, 29 Aug 2016 10:32:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.55.202 with HTTP; Mon, 29 Aug 2016 10:31:44 -0700 (PDT) X-Originating-IP: [2620:0:1003:415:bd00:554d:a06c:542b] In-Reply-To: <20160829165725.GA11270@FreeBSD.cs.nctu.edu.tw> References: <1491374121.44.1472440150670.JavaMail.jenkins@jenkins-9.freebsd.org> <166099893.51.1472451061454.JavaMail.jenkins@jenkins-9.freebsd.org> <6E443BB8-0269-4812-A2F4-40AA303E69C6@FreeBSD.org> <8058052E-A09A-403E-828A-74B51ED4BBF4@FreeBSD.org> <20160829163911.GA51650@FreeBSD.cs.nctu.edu.tw> <20160829165725.GA11270@FreeBSD.cs.nctu.edu.tw> From: Julio Merino Date: Mon, 29 Aug 2016 13:31:44 -0400 Message-ID: Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD #564 To: Li-Wen Hsu Cc: Dimitry Andric , "freebsd-testing@freebsd.org" , "jenkins-admin@freebsd.org" , Bryan Drewery Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2016 17:32:06 -0000 The -I/usr/include is coming from within ATF. When ATF is built, it gets the value of /usr/include hardcoded in the ATF_INCLUDEDIR constant, which is later used for these build-time tests. I haven't looked closely how --sysroot behaves, but I notice the following from c++'s manpage (gcc): -I dir Add the directory dir to the list of directories to be searched for header files. Directories named by -I are searched before the standard system include directories. If the directory dir is a standard system include directory, the option is ignored to ensure that the default search order for system directories and the special treatment of system headers are not defeated . If dir begins with "=", then the "=" will be replaced by the sysroot prefix; see --sysroot and -isysroot. Note the mention about =. Maybe the ATF_INCLUDEDIR constant should be changed to =/usr/include instead of just a bare /usr/include to make sure the sysroot is respected? On Mon, Aug 29, 2016 at 12:57 PM, Li-Wen Hsu wrote: > No, /usr/obj is empty while running kyua test. My VM is installed from > base.txz & kernel.txz . > > Li-Wen > > On Mon, Aug 29, 2016 at 18:50:42 +0200, Dimitry Andric wrote: > > Yes, I've also seen the --sysroot options being added recently. I'm > reasonably sure that this is the cause of the error. Bryan did most of the > restructuring for external toolchains, which also adds the --sysroot option. > > > > Is there an usr/include/c++/v1 under the --sysroot? > > > > -Dimitry > > > > > On 29 Aug 2016, at 18:39, Li-Wen Hsu wrote: > > > > > > Dimitry, are you talking about case lib.atf.libatf-c++.atf_c++_test.include > ? > > > > > > I happen to have a r304986 VM here: > > > > > > https://people.freebsd.org/~lwhsu/tmp/disk-test.img.xz > > > > > > (it starts kyua test in /etc/rc.local, just use ctrl-c to interrupt it) > > > > > > And there is a /usr/include/c++/v1 directory with sstream in it. > > > > > > > > > BTW, I am not sure removing -I/usr/include is the right solution, I > > > think this case is checking for "normal" compiling would work, not > > > during buildworld. When this case was passing, it uses following > > > command: > > > > > > c++ -O2 -pipe -DHAVE_CONFIG_H -I/usr/include -Wall -Werror -o test.o > -c test.cpp > > > > > > and now it uses: > > > > > > c++ -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/usr/src/tmp > -B/usr/obj/usr/src/tmp/usr/bin -O2 -pipe -DHAVE_CONFIG_H -I/usr/include > -Wall -Werror -o test.o -c test.cpp > > > > > > This changed between r304555 and r304698. > > > > > > > > > Also, does anyone know where is "-I/usr/include" coming from? Is this > > > one? > > > https://svnweb.freebsd.org/base/head/contrib/atf/atf-c% > 2B%2B/detail/test_helpers.cpp?view=markup#l56 > > > > > > > > > Li-Wen > > > > > > On Mon, Aug 29, 2016 at 16:02:42 +0200, Dimitry Andric wrote: > > >> Do you have an /usr/include/c++/v1 directory? And is there a file > called "sstream" in it? > > >> > > >> If it is there, I think the problem is due to the -I/usr/include > option in the command line for the test program. If you remove that, I > think the compilation will work correctly. > > >> > > >> -Dimitry > > >> > > >>> On 29 Aug 2016, at 14:55, Craig Rodrigues > wrote: > > >>> > > >>> Dimitry, > > >>> > > >>> During the Jenkins job, I use installworld/installkernel to build a > fully bootable bhyve virtual machine. > > >>> After the virtual machine boots, ssh into it, and do: > > >>> > > >>> cd /usr/tests > > >>> kyua test > > >>> kyua report --verbose > > >>> > > >>> > > >>> So I am suspecting that maybe something didn't get installed > properly? > > >>> -- > > >>> Craig > > >>> > > >>> > > >>> On Mon, Aug 29, 2016 at 4:13 AM, Dimitry Andric > wrote: > > >>> I just found the separate "test results" link in Jenkins. As far as > I can see, one of those failing tests is run as: > > >>> > > >>> c++ -target x86_64-unknown-freebsd12.0 --sysroot=/builds/workspace/ > FreeBSD_HEAD/obj/builds/workspace/FreeBSD_HEAD/src/tmp > -B/builds/workspace/FreeBSD_HEAD/obj/builds/workspace/FreeBSD_HEAD/src/tmp/usr/bin > -O2 -pipe -DHAVE_CONFIG_H -I/usr/include -Wall -Werror -o test.o -c test.cpp > > >>> > > >>> So are the libc++ headers installed in the /builds/workspace/FreeBSD_ > HEAD/obj/builds/workspace/FreeBSD_HEAD/src/tmp sysroot? The compiler > error message appears to indicate it is getting its headers from > /usr/include instead. > > >>> > > >>> I can't look on the actual test system, but my guess would be that > either the --sysroot flag is incorrect, or the libc++ headers are not > correctly installed on the target system. > > >>> > > >>> -Dimitry > > >>> > > >>>> On 29 Aug 2016, at 12:56, Dimitry Andric wrote: > > >>>> > > >>>> Hi Craig, > > >>>> > > >>>> I find it very hard to parse these extremely verbose logs. Can you > point out the location and contents of the exact error you are seeing? > > >>>> > > >>>> -Dimitry > > >>>> > > >>>>> On 29 Aug 2016, at 08:59, Craig Rodrigues > wrote: > > >>>>> > > >>>>> Dimitry, > > >>>>> > > >>>>> Can you take a look at this? > > >>>>> I'm not sure why, but after recent changes, one of the tests is > > >>>>> complaining that the C++ header is missing. > > >>>>> > > >>>>> -- > > >>>>> Craig > > >>>>> > > >>>>> > > >>>>> On Sun, Aug 28, 2016 at 11:11 PM, > wrote: > > >>>>> See > > >>>>> > > >>>>> > > >>>> > > >>> > > >>> > > >> > > > > > > > > > > > > -- > > > Li-Wen Hsu > > > https://lwhsu.org > > > > > > -- > Li-Wen Hsu > https://lwhsu.org > -- Julio Merino -- http://julio.meroh.net/