Date: Wed, 3 Mar 2021 04:53:59 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Brandon Bergren <bdragon@FreeBSD.org> Cc: Ed Maste <emaste@FreeBSD.org>, Warner Losh <imp@bsdimp.com>, Nathan Whitehorn <nwhitehorn@FreeBSD.org>, "Rodney W. Grimes" <rgrimes@FreeBSD.org>, src-committers <src-committers@FreeBSD.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@FreeBSD.org>, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in 0b7472b3d8d2. Message-ID: <202103031253.123CrxKG051357@gndrsh.dnsmgr.net> In-Reply-To: <63ccc815-d23b-44f5-8bf8-d301ce0665f7@www.fastmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> OK, how about this as an idea then: > > Parse mount output to see if anything is mounted to /boot/efi directly? > > if mount -p | cut -f 2 | grep '^/boot/efi$'; then > .... > fi What am I missing here? One place I am being told this is run in an environment that may not even be an EFI booted system, and in another place it is being used as a test if something is mounted on it, which should only be true on an EFI booted system. Using the existance of a directory or something mounted on that directory is probably one of the worse ways to make a decsiion about if the system is or is not EFI capable, or if it needs or doesnt need EFI support stuff. I often boot from a MBR sd card or usb memstick and install an EFI system on another type of media. I am sure there is stuff in the release process that has to make EFI related platform issues, and that should probably be controled by a platform specific MK_foo knob, and not by these "exists" tests. > Brandon Bergren > bdragon@FreeBSD.org -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202103031253.123CrxKG051357>