From owner-freebsd-stable@freebsd.org Fri Oct 30 18:33:42 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 646A6458A14 for ; Fri, 30 Oct 2020 18:33:42 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CN9tZ20YWz4LSf; Fri, 30 Oct 2020 18:33:42 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-WLAN.fritz.box (p200300cd5f0bbc00a80cbc70bf701be1.dip0.t-ipconnect.de [IPv6:2003:cd:5f0b:bc00:a80c:bc70:bf70:1be1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 812D4105C3; Fri, 30 Oct 2020 18:33:41 +0000 (UTC) (envelope-from se@freebsd.org) To: "Julian H. Stacey" Cc: Diane Bruce , Greg Balfour , freebsd-stable References: <202010292348.09TNmXiX022948@fire.js.berklix.net> From: Stefan Esser Subject: Re: calendar (1) - patch to correct error description Message-ID: <60d7c6ac-7e03-2daa-fd1d-000be6b5ace8@freebsd.org> Date: Fri, 30 Oct 2020 19:33:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <202010292348.09TNmXiX022948@fire.js.berklix.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WVdDpY4grSrrJXNrG23bRSJlyUO5qdgqR" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 18:33:42 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WVdDpY4grSrrJXNrG23bRSJlyUO5qdgqR Content-Type: multipart/mixed; boundary="qUcUdhluoUuOUzwl1B5NyIRbmxbbTXM1S"; protected-headers="v1" From: Stefan Esser To: "Julian H. Stacey" Cc: Diane Bruce , Greg Balfour , freebsd-stable Message-ID: <60d7c6ac-7e03-2daa-fd1d-000be6b5ace8@freebsd.org> Subject: Re: calendar (1) - patch to correct error description References: <202010292348.09TNmXiX022948@fire.js.berklix.net> In-Reply-To: <202010292348.09TNmXiX022948@fire.js.berklix.net> --qUcUdhluoUuOUzwl1B5NyIRbmxbbTXM1S Content-Type: multipart/mixed; boundary="------------952E8770B933A1E93F81BF29" Content-Language: en-US This is a multi-part message in MIME format. --------------952E8770B933A1E93F81BF29 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Am 30.10.20 um 00:48 schrieb Julian H. Stacey: > Here's another 2 calendar errors, presumably cpp, that manifest in 12.2= -STABLE, > that 9.2-RELEASE gets right. >=20 > Man calendar: > Empty lines and lines protected by the C commenting syntax > (/* ... */) are ignored. >=20 > --- Input ~/.calendar/calendar > friday fish > /* > * Oct 21 AAA > */ > friday and chips > ---12.2-STABLE output > Oct 30* and chips > Oct 30 AAA > Oct 30* fish > Oct 31 AAA > ---9.2-RELEASE output > Oct 30* and chips > Oct 30* fish > --- >=20 > Error 1: Why does it emit AAA ? The version you used does only support /* ... */ on a single line. The "*" in front of "Oct" seems to have been parsed as a wild-card, but I have not checked why it lead to be interpreted as "Oct 30". This is fixed with the comment processing that I have added to the internal pre-processor. > Error 2: Why twice ? No idea and I do not consider this relevant now that the issue is fixed. > Puzzle: Doesnt happen if you change Oct above to Aug inside the commen= t. Feel free to solve this puzzle, I really do not have the time to waste on this question ;-) > (PS both do a nasty stack unstack, which may look familiar to us > programmers, but looks silly to normal peopler, inverting fish & chips)= Yes, a linked list that got built-up be putting the new element at the head and the previously added values into the "next" field of that element. Please check the calendar version in -CURRENT or the deskutil/calendar port version 0.6. Both issues should be fixed there. Regards, STefan --------------952E8770B933A1E93F81BF29-- --qUcUdhluoUuOUzwl1B5NyIRbmxbbTXM1S-- --WVdDpY4grSrrJXNrG23bRSJlyUO5qdgqR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl+cXIMFAwAAAAAACgkQR+u171r99USi AwgAnfGQy4FDglTewJx5ow0gndPtV01j53dMgYTCtTZub897tYP+zrYxFVgsuLRy6rakLukF52IE 7ddEiR6BZpNu6PzKNp3W40V8OWzOtb6DNbEpWiHlZa2U3dMDb2AAcxjAeuBf/2uhclesAgVA9kE9 sGZZsHPPPjYYe0pwxOb1TgZmX2WzuM/cBLsdPmGbhUBwB8MHywTz1K4Eqf+cXkXwieBOlpru7qRd 7uuDKjXQOwxcPX5p10nNKyXTTLm98HYLkmIVm2rnd9/zxs8Xexcgrrmp5kEXdBYO4gzySIOD+jdn IEJZM7ApE1SUrjzO5NRYn57IS5ls7bTwZvyTnKFOPg== =TEtC -----END PGP SIGNATURE----- --WVdDpY4grSrrJXNrG23bRSJlyUO5qdgqR--