From owner-svn-src-head@freebsd.org  Tue Jun  5 02:47:42 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB22DFE2F58;
 Tue,  5 Jun 2018 02:47:42 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5305478A14;
 Tue,  5 Jun 2018 02:47:42 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w552lcGh098577;
 Mon, 4 Jun 2018 19:47:38 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w552lcRx098576;
 Mon, 4 Jun 2018 19:47:38 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201806050247.w552lcRx098576@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r334630 - head/usr.bin/indent
In-Reply-To: <1528164479.32688.223.camel@freebsd.org>
To: Ian Lepore <ian@freebsd.org>
Date: Mon, 4 Jun 2018 19:47:38 -0700 (PDT)
CC: rgrimes@freebsd.org, Piotr Pawel Stefaniak <pstef@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jun 2018 02:47:43 -0000

[ Charset ISO-8859-1 unsupported, converting... ]
> On Mon, 2018-06-04 at 17:00 -0700, Rodney W. Grimes wrote:
> > > 
> > > Author: pstef
> > > Date: Mon Jun??4 20:24:31 2018
> > > New Revision: 334630
> > > URL: https://svnweb.freebsd.org/changeset/base/334630
> > > 
> > > Log:
> > > ? indent(1): remove static const char copyright[]
> > > ??
> > > ? It repeats what is already said in the heading comment and it's optimized out
> > > ? so serves no purpose.
> > The purpose would be to put a copyright into the binary, and why that is not
> > happening when the original authors intended that is not good.
> > 
> > This is a regression, as 5.4p8 shows:
> > {108}% strings /usr/bin/indent | grep -i copy
> > bcopy
> > @(#) Copyright (c) 1985 Sun Microsystems, Inc.
> > @(#) Copyright (c) 1976 Board of Trustees of the University of Illinois.
> > @(#) Copyright (c) 1980, 1993
> > 
> > Please walk very very very carefully around all things "copyright".
> > 
> 
> Does it matter what the original author intended?
Yes, it does.

> Nothing in the
> license text itself requires that copyright info be included in the
> binary (it just has to be in the docs and accompanying materials). So
> why would an edit to remove that from the binary be any different than
> any other edit to the code that any committer chooses to make?

Because he deleted lines that contain the word "copyright"
and that is just a dangerious place to play.


-- 
Rod Grimes                                                 rgrimes@freebsd.org