From owner-freebsd-hackers Sat Feb 17 07:33:37 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id HAA15232 for hackers-outgoing; Sat, 17 Feb 1996 07:33:37 -0800 (PST) Received: from frig.mt.cs.keio.ac.jp (frig.mt.cs.keio.ac.jp [131.113.32.7]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id HAA15226 for ; Sat, 17 Feb 1996 07:33:31 -0800 (PST) Received: (from hosokawa@localhost) by frig.mt.cs.keio.ac.jp (8.6.12+2.4W/3.4Wbeta3) id AAA06288; Sun, 18 Feb 1996 00:33:26 +0900 Date: Sun, 18 Feb 1996 00:33:26 +0900 Message-Id: <199602171533.AAA06288@frig.mt.cs.keio.ac.jp> To: hackers@freebsd.org Subject: sysinstall bug? From: hosokawa@mt.cs.keio.ac.jp (HOSOKAWA Tatsumi) X-Mailer: mnews [version 1.18PL3] 1994-08/01(Mon) Sender: owner-hackers@freebsd.org Precedence: bulk Hi! I'm making PC-card ready floppy for 2.1.0R and I found a bug (?) of original sysinstall. This bug has not fixed on -current. --- devices.c.orig Wed Nov 15 15:57:02 1995 +++ devices.c Sat Feb 17 18:53:59 1996 @@ -319,8 +319,9 @@ continue; /* Eliminate network devices that don't make sense */ if (!strncmp(ifptr->ifr_name, "tun", 3) + || !strncmp(ifptr->ifr_name, "sl", 2) || !strncmp(ifptr->ifr_name, "lo0", 3)) - continue; + goto loopend; deviceRegister(ifptr->ifr_name, ifptr->ifr_name, ifptr->ifr_name, DEVICE_TYPE_NETWORK, TRUE, mediaInitNetwork, NULL, NULL, mediaShutdownNetwork, NULL); msgDebug("Found a device of type network named: %s\n", ifptr->ifr_name); @@ -330,6 +331,7 @@ msgConfirm("ifconfig: socket"); continue; } +loopend: if (ifptr->ifr_addr.sa_len) /* I'm not sure why this is here - it's inherited */ ifptr = (struct ifreq *)((caddr_t)ifptr + ifptr->ifr_addr.sa_len - sizeof(struct sockaddr)); } -- HOSOKAWA, Tatsumi E-mail: hosokawa@mt.cs.keio.ac.jp WWW homepage: http://www.mt.cs.keio.ac.jp/person/hosokawa.html Department of Computer Science, Keio University, Yokohama, Japan