From owner-svn-src-head@freebsd.org Thu Aug 9 01:15:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C3241072240 for ; Thu, 9 Aug 2018 01:15:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E791768C4 for ; Thu, 9 Aug 2018 01:15:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22e.google.com with SMTP id i18-v6so3417179ioj.13 for ; Wed, 08 Aug 2018 18:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4OmLy8XtdfSbqSbrCftETJqRK/iF5pk0DRFkIWknc0A=; b=O5zj3Hozp2geSzUFu/TdcMqzu7QZ1EsFPTB87mOTUTgyi6d1TR7fPLqCYXilgq/Vc3 gMI3YqedEkalmFOqxS3h5XLAQ0gbvnDMEysGvQNS55rTJMKhpjvNW0hzZxarWR+EPcy6 ffBzDHcvw60umNYPe+HTWB3FFv/ZyELx14if3fbbjfzKcatBx0WPIDTE7wK2wKXn7yTr 8JzY7DNpiCnwu2TQOCizfKfI9EQUZMwWjHtzrLCzw/F8OuKdWyRU/aFDYWK2Ym0BjPkm Eg75WMsM2MOwQ1NTaZChtjVfZuW4RkhFfHIjiVjBIKkb468ssAJ6yE+xYyonmzFe06As c0AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4OmLy8XtdfSbqSbrCftETJqRK/iF5pk0DRFkIWknc0A=; b=Iw8XqiTeDzHBhAhDR4wqIEM74YV2dTkExJNv8uU1/oLct0BuwtsOLTWtg+LBk1880/ /sgCuLiIVyL0w7YXj0UcPVj+v49Ib7YJINvX52kSPPNl3fTZLaA3RzcTHf8hS23fhybu BQ0lxRsrFF1ftg7hojbEncyS9YL7mQOSFqaAM29HZjwJQQzTo+iSDkF1hBJNvXiVS22U 7kGrbFXsZxwN4fyrrfN3ctTiF0kYsME2n+fSRaJBKOTwrn9muGG7tOW3QyvXJCDPfo3L FwsllopeEyEX4J4msTFOoszGirv8GtmoSxAzC7XVfgPZ9N1tHWEy07ruQj1BoZJhqyP3 DHVQ== X-Gm-Message-State: AOUpUlE4bIipVj52IeRhGvcJt7xJYFjFRYAlmsX/8DhuDTMky2VySxap V9ZgHTEyBrBBv28O2cDnGqRrSgdnk6ikJttt+PSE+w== X-Google-Smtp-Source: AA+uWPxYGSwVyYKlmuGSAhKWKEhBdwyn6HugtbBIWloSs9CQlW5diKZ931350n4vcRnNSLSXymPSQYDcrtL679NLqlM= X-Received: by 2002:a6b:f70f:: with SMTP id k15-v6mr37755iog.37.1533777333810; Wed, 08 Aug 2018 18:15:33 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:381a:0:0:0:0:0 with HTTP; Wed, 8 Aug 2018 18:15:33 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201808082137.w78Lb2B5031967@repo.freebsd.org> From: Warner Losh Date: Wed, 8 Aug 2018 19:15:33 -0600 X-Google-Sender-Auth: jdGdFqdz13MkbxNAiTntpJ6kl74 Message-ID: Subject: Re: svn commit: r337505 - head/bin/dd To: Kyle Evans Cc: Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 01:15:35 -0000 On Wed, Aug 8, 2018 at 7:01 PM, Kyle Evans wrote: > On Wed, Aug 8, 2018 at 7:58 PM, Eitan Adler wrote: > > On Wed, 8 Aug 2018 at 14:37, Kyle Evans wrote: > >> +/* ARGSUSED */ > > > > We've been slowly delintifying system utilities. Why do we still keep > > these comments? > > > > This is consistent with the style of the file, so I didn't object. > I'd rather do another pass later to de-lintify the whole thing rather > than nitpick at this patch for some otherwise harmless and matching > comments. =) > It appears to be from NetBSD upstream, so removing it would be pointless churn that makes things harder to merge. Warner