Date: Mon, 13 Jan 2014 01:26:52 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Chris Rees <crees@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r339550 - in head/Mk: . Uses Message-ID: <20140113002652.GN97375@ithaqua.etoilebsd.net> In-Reply-To: <20140113002034.GM97375@ithaqua.etoilebsd.net> References: <201401122116.s0CLG6Wn016253@svn.freebsd.org> <20140113002034.GM97375@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--i6vqABX3nJKXLk01 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 13, 2014 at 01:20:34AM +0100, Baptiste Daroussin wrote: > On Sun, Jan 12, 2014 at 09:16:06PM +0000, Chris Rees wrote: > > Author: crees > > Date: Sun Jan 12 21:16:06 2014 > > New Revision: 339550 > > URL: http://svnweb.freebsd.org/changeset/ports/339550 > >=20 > > Log: > > Strip postgresql code out of bsd.database.mk, and introduce USES=3Dpg= sql. > > =20 > > New syntax: > > =20 > > # Depend on postgresql-client > > USES=3D pgsql > > =20 > > # Depend on postgresql-client at least 9.2 > > USES=3D pgsql:9.2+ > > =20 > > #Depend on postgresql-server at least 9.0 > > USES=3D pgsql:9.0+ > > WANT_PGSQL=3D server > > =20 > > Postgresql now supports DEFAULT_VERSIONS, and please note that the > > version syntax now includes dots(!); i.e. before it was 90, now 9.0 > > =20 > > Reviewed by: ade, silence from pgsql@ > >=20 >=20 > It is broken in multiple parts first WANT_PGSQL is checked even when not = defined > resulting multiple lines like: > /usr/ports/Mk/Uses/pgsql.mk" line 128: Malformed conditional (${WANT_PGSQ= L:M${:Ucontrib}}) > if a port only defines USES=3Dpgsql >=20 > If the first is fixed then the version is not properly defined resulting = in a > dependency like: > /usr/ports/databases/postgresql-client which doesn't exists. >=20 > For this kind of change a portmgr review would have been nice and an exp-= run > even better. Yet more things: there is mess up between what should be run in pre or post section which is normally one of the things USES should solve and makes Mk/* inefficient and lots of the time not predictable this is a major pain when debugging. Bapt --i6vqABX3nJKXLk01 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLTMswACgkQ8kTtMUmk6Ez77ACcD0Pp0wrGYSnEmHYrF7BjCHu6 JqEAn0KbhKGON3C1i9goUHWO2igg4LG9 =3C3B -----END PGP SIGNATURE----- --i6vqABX3nJKXLk01--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140113002652.GN97375>