Date: Tue, 15 Aug 2006 13:10:22 GMT From: mglaum@sdf.lonestar.org To: freebsd-geom@FreeBSD.org Subject: Re: kern/98538: [geom] Kernel panic on ggate destroy Message-ID: <200608151310.k7FDAMQF019458@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/98538; it has been noted by GNATS.
From: mglaum@sdf.lonestar.org
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: kern/98538: [geom] Kernel panic on ggate destroy
Date: Tue, 15 Aug 2006 13:08:07 -0000 (UTC)
A quick glance at /usr/src/sys/geom/gate/g_gate.c, I suspect the problem
is that in the g_gate_ioctl() switch case G_GATE_CMD_DESTROY, there's a
mtx_lock() but no subsequent mtx_unlock().
I've got a patch devised, below, but do not have the time or resources
to try it. Would someone be willing to review this, try a patch and run
a test? The Makefile is in /usr/src/sys/modules/geom/geom_gate. Again,
I'm not sure about the positioning of the mtx_unlock().
Michael Glaum
KVH Industries
mglaum@kvh.com
[patch for /usr/src/sys/geom/gate/g_gate.c]
--- g_gate.c Tue Aug 1 16:00:34 2006
+++ g_gate.c.orig Tue Aug 1 16:00:02 2006
@@ -487,7 +487,6 @@
error = g_gate_destroy(sc, ggio->gctl_force);
if (error == 0)
g_gate_wither(sc);
- mtx_unlock(&g_gate_list_mtx);
g_topology_unlock();
g_gate_release(sc);
return (error);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608151310.k7FDAMQF019458>