From owner-freebsd-stable@FreeBSD.ORG Thu May 29 06:34:49 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7F1ACC4C for ; Thu, 29 May 2014 06:34:49 +0000 (UTC) Received: from mail-qg0-x230.google.com (mail-qg0-x230.google.com [IPv6:2607:f8b0:400d:c04::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3768D22A3 for ; Thu, 29 May 2014 06:34:49 +0000 (UTC) Received: by mail-qg0-f48.google.com with SMTP id i50so20897303qgf.7 for ; Wed, 28 May 2014 23:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dataix.net; s=rsa; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=J1TsuwMHUXVi0Mwi7/DBBu36gQEJEwfEhsPI4vsh7go=; b=fclImDoRFZHT7HJNFNYJK1lxC29nUZTyQNkXPnbW+FhIAVeN/Il3Po6lQ0xXYpEBYh SkqGt4L/OccHPmgRMdOiTu67SVrJXFWVJ3U2yCO20Bz0/jPZ8jCbTGQq0lEVCWabzobP dyvwzlnuGRTq4jRmaT7FCR2VQlUjB6V7gFmKQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=J1TsuwMHUXVi0Mwi7/DBBu36gQEJEwfEhsPI4vsh7go=; b=jbNMkmx/HMBaPDKAgn3SPLcTtkYqo6khSMzPMf1M9YDa1e+GJpwuO73thY+a7pj+L1 RxKmLJVG3U8QNiUjydo16Y8uqNMW+ycepI2ax7/jKtBi72oeWCoiw1fwjOT+07L80Ruy Xh7niUdu/EKUKfaxiuuR4dqllZBR+Uz3XdHoHAEr0BYQEgZcjBmX2pnMxdXXK1n0EqwX sTu2IDKyqL4Tp+DS2Jv6iZIqQ4VY4woPTfwfXoJUKssx7Cpooz+oYaVPdEV20dJ6f4QX 4jbdWGUqSCQr67/FB8u96g97aOJuu3zOx/pcRsWCMEB2FhvlHO5PdIWKApCc6s0ANWhh l26g== X-Gm-Message-State: ALoCoQm0JI9pNz7Fx6kiE5MvbZGyfa/owB93YdDgAz8PnFHYVyvzC5tuYOKpazWbBrAaUouCGZ5h MIME-Version: 1.0 X-Received: by 10.140.23.7 with SMTP id 7mr6726303qgo.0.1401345288130; Wed, 28 May 2014 23:34:48 -0700 (PDT) Received: by 10.140.92.198 with HTTP; Wed, 28 May 2014 23:34:47 -0700 (PDT) X-Originating-IP: [75.128.101.59] Date: Thu, 29 May 2014 02:34:47 -0400 Message-ID: Subject: [VIMAGE][udplite] FreeBSD 10-STABLE/powerpc From: Jason Hellenthal To: "[FreeBSD Stable]" , "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: kevlo@freebsd.org, adrian@freebsd.org, Gleb Smirnoff , jhb@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2014 06:34:49 -0000 Is anyone aware that VIMAGE on powerpc is currently broken ? In file included from /export/usr/src/sys/netinet/in_proto.c:83: /export/usr/src/sys/netinet/udp_var.h: In function 'get_inpcbinfo': /export/usr/src/sys/netinet/udp_var.h:153: error: dereferencing pointer to incomplete type /export/usr/src/sys/netinet/udp_var.h:153: error: dereferencing pointer to incomplete type /export/usr/src/sys/netinet/udp_var.h: In function 'get_pcblist': /export/usr/src/sys/netinet/udp_var.h:159: error: dereferencing pointer to incomplete type /export/usr/src/sys/netinet/udp_var.h:159: error: dereferencing pointer to incomplete type *** Error code 1 The relevant code in that header is: get_inpcbinfo(uint8_t protocol) { return (protocol == IPPROTO_UDP) ? &V_udbinfo : &V_ulitecbinfo; } get_pcblist(uint8_t protocol) { return (protocol == IPPROTO_UDP) ? &V_udb : &V_ulitecb; } Working Copy Root Path: /usr/src URL: svn://svn.freebsd.org/base/stable/10 Relative URL: ^/stable/10 Repository Root: svn://svn.freebsd.org/base Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f Revision: 266818 Node Kind: directory Schedule: normal Last Changed Author: delphij Last Changed Rev: 266816 Last Changed Date: 2014-05-28 14:51:49 -0400 (Wed, 28 May 2014) Also looking at svn it appears to have come from this commit... I have backed out the change here and it appears to be following through so more attention to VIMAGE and udplite seems to be needed. ------------------------------------------------------------------------ r265946 | kevlo | 2014-05-13 02:05:53 -0400 (Tue, 13 May 2014) | 14 lines Changed paths: M /stable/10 M /stable/10/lib/libc/net/getaddrinfo.c M /stable/10/sys/netinet/in.c M /stable/10/sys/netinet/in.h M /stable/10/sys/netinet/in_pcb.c M /stable/10/sys/netinet/in_proto.c M /stable/10/sys/netinet/udp_usrreq.c M /stable/10/sys/netinet/udp_var.h A /stable/10/sys/netinet/udplite.h (from /head/sys/netinet/udplite.h:264212) M /stable/10/sys/netinet6/in6_ifattach.c M /stable/10/sys/netinet6/in6_proto.c M /stable/10/sys/netinet6/udp6_usrreq.c M /stable/10/sys/netinet6/udp6_var.h M /stable/10/sys/sys/param.h MFC r264212,r264213,r264248,r265776,r265811,r265909: - Add support for UDP-Lite protocol (RFC 3828) to IPv4 and IPv6 stacks. Tested with vlc and a test suite [1]. [1] http://www.erg.abdn.ac.uk/~gerrit/udp-lite/files/udplite_linux.tar.gz Reviewed by: jhb, glebius, adrian - Fix a logic bug which prevented the sending of UDP packet with 0 checksum. - Disable TX checksum offload for UDP-Lite completely. It wasn't used for partial checksum coverage, but even for full checksum coverage it doesn't work. ------------------------------------------------------------------------