From owner-freebsd-current Fri Aug 9 3: 4:31 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CAB837B400 for ; Fri, 9 Aug 2002 03:04:28 -0700 (PDT) Received: from mail.tgd.net (mail.tgd.net [209.81.25.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15A8243E3B for ; Fri, 9 Aug 2002 03:04:28 -0700 (PDT) (envelope-from sean@mail.tgd.net) Received: by mail.tgd.net (Postfix, from userid 1001) id E332120F05; Fri, 9 Aug 2002 03:04:27 -0700 (PDT) Date: Fri, 9 Aug 2002 03:04:27 -0700 From: Sean Chittenden To: current@freebsd.org Subject: w/uptime warning inappropriately under xdm/kdm [patch]... Message-ID: <20020809100427.GA65519@ninja1.internal> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline User-Agent: Mutt/1.4i X-PGP-Key: 0x1EDDFAAD X-PGP-Fingerprint: C665 A17F 9A56 286C 5CFB 1DEA 9F4F 5CEF 1EDD FAAD X-Web-Homepage: http://sean.chittenden.org/ Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I've switched one of my desktops to using kdm and I've noticed that w(1) creates suprious warnings because it can't find the tty entry. $ w w: /dev/:0: No such file or directory w: /dev/:0: No such file or directory 2:41AM up 49 mins, 0 users, load averages: 0.05, 0.04, 0.04 USER TTY FROM LOGIN@ IDLE WHAT $ I've included a patch that quiets this. The attached patch is inline with the behavior from who(1). Are there any objections to it? What should be the correct behaviour when loggin in via xdm/kdm? Is there a better way to detect that you're logged in via xdm/kdm? Should w(1) iterate through utmp/wtmp to get user info? -sc -- Sean Chittenden --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch Index: w.c =================================================================== RCS file: /home/ncvs/src/usr.bin/w/w.c,v retrieving revision 1.54 diff -u -r1.54 w.c --- w.c 2002/06/07 01:41:54 1.54 +++ w.c 2002/08/09 09:57:17 @@ -491,11 +491,10 @@ char ttybuf[MAXPATHLEN]; (void)snprintf(ttybuf, sizeof(ttybuf), "%s%.*s", _PATH_DEV, sz, line); - if (stat(ttybuf, &sb)) { - warn("%s", ttybuf); + if (stat(ttybuf, &sb) == 0) { + return (&sb); + } else return (NULL); - } - return (&sb); } static void --xHFwDpU9dbj6ez1V-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message