From owner-cvs-src@FreeBSD.ORG Sat Sep 20 13:49:13 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5E8616A4B3; Sat, 20 Sep 2003 13:49:13 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id E36A643FD7; Sat, 20 Sep 2003 13:49:10 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h8KKnA2d011225; Sat, 20 Sep 2003 13:49:10 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) h8KKnAX7001421; Sat, 20 Sep 2003 13:49:10 -0700 (PDT) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.10/8.12.10/Submit) id h8KKnAVm001420; Sat, 20 Sep 2003 13:49:10 -0700 (PDT) (envelope-from marcel) Date: Sat, 20 Sep 2003 13:49:10 -0700 From: Marcel Moolenaar To: "Alan L. Cox" Message-ID: <20030920204910.GA1382@athlon.pn.xcllnt.net> References: <200309201927.h8KJRm9e006832@repoman.freebsd.org> <3F6CAFAA.F48E2A12@imimic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F6CAFAA.F48E2A12@imimic.com> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/conf files.ia64 src/sys/ia64/ia64 pmap.cuma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Sep 2003 20:49:14 -0000 On Sat, Sep 20, 2003 at 02:51:06PM -0500, Alan L. Cox wrote: > > Added files: > > sys/ia64/ia64 uma_machdep.c > > Log: > > Move uma_small_alloc() and uma_small_free() to uma_machdep.c. These > > functions reference UMA internals from , which makes > > them highly unwanted in non-UMA specific files. *snip* > An observation ... we now have three different locations, on four > different architectures, for these functions. I definitely agree that > pmap.c is the wrong place because these functions have nothing to do > with page table and/or TLB management. Long ago, I encouraged Jake to > start a trend for the better by placing the sparc64 implementations in > vm_machdep.c. Whether it's uma_machdep.c or vm_machdep.c doesn't matter > much to me, only that we arrive at a consensus on which it is. I would > observe the similarities to the new, optimized amd64 and ia64 > sf_buf_alloc() implementations as an argument for vm_machdep.c. I originally placed them in vm_machdep.c, but noticed I had to pull in more headers, including . At that time I opted for uma_machdep.c. If you think vm_machdep.c is good enough then let's move them there. Make the call. I'll follow suit. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net