From owner-freebsd-current@freebsd.org Fri Apr 28 21:43:39 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A990ED54074 for ; Fri, 28 Apr 2017 21:43:39 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 09D04180C for ; Fri, 28 Apr 2017 21:43:38 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA21925; Sat, 29 Apr 2017 00:43:35 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1d4Dfr-0007Xp-Q4; Sat, 29 Apr 2017 00:43:35 +0300 Subject: Re: Panic String: solaris assert: (lsize != psize) implies ((flags & ZIO_FLAG_RAW) != 0), file: /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c, line: 631 To: Michael Jung Cc: freebsd-current@FreeBSD.org References: <32c84a1f-1377-e0a1-1c8b-d22eea80d871@FreeBSD.org> <19ac2524eba83333063822c063c6af3e@mikej.com> From: Andriy Gapon Message-ID: <75e7cde3-b064-5754-192d-00f8a65788b8@FreeBSD.org> Date: Sat, 29 Apr 2017 00:42:45 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <19ac2524eba83333063822c063c6af3e@mikej.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 21:43:39 -0000 On 28/04/2017 14:56, Michael Jung wrote: > I have mad the requested change.. > > [root@bsd11 /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs]# diff zio.c > ~mikej/zio.c.orig > 965c965 > < size, NULL, NULL, ZIO_TYPE_FREE, ZIO_PRIORITY_NOW, > --- >> BP_GET_PSIZE(bp), NULL, NULL, ZIO_TYPE_FREE, ZIO_PRIORITY_NOW, Yes, that's the change that I had in mind. I was a little bit confused by the order of the original and modified files, though :-) > [root@bsd11 /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs]# > > As to the pool size: > > [root@bsd11 /usr/home/mikej]# zpool list > NAME SIZE ALLOC FREE EXPANDSZ FRAG CAP DEDUP HEALTH ALTROOT > tank 199G 143G 55.9G - 85% 71% 1.00x ONLINE - > [root@bsd11 /usr/home/mikej]# > > I should have also mentioned that besides poudriere running a build, it was > removing old logs - There was some 43G of old logs files that were in the process > of being removed. So, given that the panic was in the freeing path, you were probably low on the pool space back when those log files were created. I mean that the gang blocks are typically created when a pool is very fragmented. > I will hammer the box with and report back first of the week whether the panic > re-occurs or not. Please also try removing those old files again too. Running zpool scrub afterwards could be a good idea too. Thank you again! -- Andriy Gapon