From nobody Fri Jul 29 21:00:38 2022 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lvg0s5F9Bz4CLmq; Fri, 29 Jul 2022 21:01:17 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lvg0s0TRyz3Lh6; Fri, 29 Jul 2022 21:01:17 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-pj1-f51.google.com with SMTP id q7-20020a17090a7a8700b001f300db8677so6336523pjf.5; Fri, 29 Jul 2022 14:01:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc; bh=iwVZUAEJDr08IeoM1hh37hkBe0zn/OrciGAUlJ0j788=; b=73FR198IdSvBK71z1NSbBUf8UAY1r+g4kbMNS37Y37RR+wt0AbntQ45ZYwCcxXLAnC F5ESgmMWvkdDHY+ga+hBmqyOBvysjUXfSVF+CiZuyXVOHsnbb3pTcekz2mO4RBKQ1jHN yh10SU6Ci+GnTm97yHp3pisehS2f2LqAAM+DIRPExVgwBXndcT+x83XrzzePax6XgkHa 7rLjVfwUgrKL5tgw63yQq4ZUkLOGC4GJcbjfd1634hF5gDUicEL8aC4N1/HF3g+daMen XFg3xkR413ssxPu8OKzF9KjQCAG7WRJuC0qzNsMD62b7D7jicnSXc/iSWf3R546EVBoo 0uKg== X-Gm-Message-State: ACgBeo0uj2VeovGSNmbe39eC8WOWuy7UAgV17EyjR5HGg5kaLtUIZY1c SxzYWasPSSmzsOhOabDaA1MQWHMR8NE= X-Google-Smtp-Source: AA6agR6pHvXIzUfLeuSeFi0JwihRG5cMLk3dbxr1HL//Mj4sGeZPpBMNAJEA8km/6Jon/3Xh63+FDA== X-Received: by 2002:a17:90b:4f4e:b0:1ef:ab40:b345 with SMTP id pj14-20020a17090b4f4e00b001efab40b345mr6148215pjb.226.1659128474965; Fri, 29 Jul 2022 14:01:14 -0700 (PDT) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com. [209.85.214.172]) by smtp.gmail.com with ESMTPSA id u10-20020a17090a6a8a00b001eafa265869sm6267996pjj.56.2022.07.29.14.01.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 14:01:14 -0700 (PDT) Received: by mail-pl1-f172.google.com with SMTP id y15so5603922plp.10; Fri, 29 Jul 2022 14:01:14 -0700 (PDT) X-Received: by 2002:a17:90b:4d05:b0:1e2:bf91:8af2 with SMTP id mw5-20020a17090b4d0500b001e2bf918af2mr6175566pjb.210.1659128474142; Fri, 29 Jul 2022 14:01:14 -0700 (PDT) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 From: Eric Joyner Date: Fri, 29 Jul 2022 14:00:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Looking for feedback on change to iflib and transmit queuing To: freebsd-net , FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000568da205e4f7f300" X-Rspamd-Queue-Id: 4Lvg0s0TRyz3Lh6 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-3.03 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997]; NEURAL_HAM_SHORT(-0.99)[-0.995]; NEURAL_HAM_LONG(-0.94)[-0.941]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.216.51:from]; RCVD_IN_DNSWL_NONE(0.00)[209.85.216.51:from,209.85.214.172:received]; MLMMJ_DEST(0.00)[freebsd-net@freebsd.org,freebsd-current@freebsd.org]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCPT_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-ThisMailContainsUnwantedMimeParts: N --000000000000568da205e4f7f300 Content-Type: text/plain; charset="UTF-8" Hi, I have a Phabricator review here that I was hoping to get some feedback on: https://reviews.freebsd.org/D34742 In short, there's already some functionality in current and 13.1-RELEASE that allows a driver to pick a TX queue for a packet, but this extends that support to have iflib do some limited parsing in order to give the driver function extra information in order to make a decision. Performance-wise this doesn't seem to affect much; I looked at it in VTune across different types of netperf runs with small packets that want L4 checksums. In fact, that made me find out that iflib_parse_header() does tons of unnecessary m_pullups() on small UDP packets; as much as 10% of the CPU time can be spent just doing that. It should maybe get modified to not pull-up to the TCP header length for UDP packets. - Eric --000000000000568da205e4f7f300 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, I have a Phabricator review here that I was hoping to = get some feedback on:=C2=A0h= ttps://reviews.freebsd.org/D34742

In short, there= 9;s already some functionality in current and 13.1-RELEASE that allows a dr= iver to pick a TX queue for a packet, but this extends that support to have= iflib do some limited parsing in order to give the driver function extra i= nformation in order to make a decision. Performance-wise this doesn't s= eem to affect much; I looked at it in VTune across different types of netpe= rf runs with small packets that want L4 checksums.

In fact, that made me find out that iflib_parse_header() does tons of unne= cessary m_pullups() on small UDP packets; as much as 10% of the CPU time ca= n be spent just doing that. It should maybe get modified to not pull-up to = the TCP header length for UDP packets.

- Eric
--000000000000568da205e4f7f300--