From owner-p4-projects@FreeBSD.ORG  Thu Jun 24 07:20:46 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 346111065674; Thu, 24 Jun 2010 07:20:46 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ECC661065670;
	Thu, 24 Jun 2010 07:20:45 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe13.swip.net [212.247.155.129])
	by mx1.freebsd.org (Postfix) with ESMTP id 549BE8FC0A;
	Thu, 24 Jun 2010 07:20:44 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=J50yT95GBfoA:10 a=ADBQPqJMlbwA:10
	a=Q9fys5e9bTEA:10 a=M8b_wTzEtboA:10
	a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=6I5d2MoRAAAA:8
	a=z5azl8PKR2wem9wTSbEA:9 a=dRD3_ai0JEjBYkIdwoFSAX14Zs0A:4
	a=PUjeQqilurYA:10
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe13.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 1020385671; Thu, 24 Jun 2010 09:20:43 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Rafal Jaworowski <raj@freebsd.org>
Date: Thu, 24 Jun 2010 09:17:51 +0200
User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.4; amd64; ; )
References: <201006232001.o5NK1moY063395@repoman.freebsd.org>
In-Reply-To: <201006232001.o5NK1moY063395@repoman.freebsd.org>
X-Face: +~\`s("[*<S!NI[0M*"FaghA8S>|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(; _IjlA:
	hGE..Ew, XAQ*o#\/M~SC=S1-f9{EzRfT'|Hhll5Q]ha5Bt-s|oTlKMusi:1e[wJl}kd}GR
	Z0adGx-x_0zGbZj'e(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L'
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201006240917.51965.hselasky@c2i.net>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 180162 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jun 2010 07:20:46 -0000

On Wednesday 23 June 2010 22:01:48 Rafal Jaworowski wrote:
> http://p4web.freebsd.org/@@180162?ac=10
> 
> Change 180162 by raj@raj_nand on 2010/06/23 20:01:21
> 
> 	Unlock properly in a failing case.
> 
> 	Submitted by:	Yohanes Nugroho
> 
> Affected files ...
> 
> .. //depot/projects/nand2/sys/dev/nand/nand_cdev.c#2 edit
> 
> Differences ...
> 
> ==== //depot/projects/nand2/sys/dev/nand/nand_cdev.c#2 (text+ko) ====
> 
> @@ -210,6 +210,7 @@
>  	if (off != 0 || (len % cg->page_size) != 0) {
>  		printf("Not aligned write start [0x%08x] size [0x%08x]\n",
>  		    off, len);
> +		nandbus_lock(nandbus);
>  		return (EINVAL);
>  	}
> 

nandbus_unlock() ???

--HPS