From owner-svn-src-all@freebsd.org Tue Nov 1 15:49:39 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1600EC2983C for ; Tue, 1 Nov 2016 15:49:39 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A97701D7F; Tue, 1 Nov 2016 15:49:38 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [IPv6:2a00:e10:2800::a135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id uA1Fna5A067200; Tue, 1 Nov 2016 16:49:37 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (titan.inop.mo1.omnilan.net [IPv6:2001:a60:f0bb:1::3:1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id A6F68236; Tue, 1 Nov 2016 16:49:36 +0100 (CET) Message-ID: <5818B990.2010400@omnilan.de> Date: Tue, 01 Nov 2016 16:49:36 +0100 From: Harry Schmalzbauer Organization: OmniLAN User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; de-DE; rv:1.9.2.8) Gecko/20100906 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: John Baldwin CC: svn-src-all@freebsd.org Subject: Re: svn commit: r297568 - head/sys/dev/fdc References: <201604050008.u3508gWj068936@repo.freebsd.org> In-Reply-To: <201604050008.u3508gWj068936@repo.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]); Tue, 01 Nov 2016 16:49:37 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: ; Sender-helo: mh0.gentlemail.de; ) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2016 15:49:39 -0000 Bezüglich John Baldwin's Nachricht vom 05.04.2016 02:08 (localtime): > Author: jhb > Date: Tue Apr 5 00:08:42 2016 > New Revision: 297568 > URL: https://svnweb.freebsd.org/changeset/base/297568 > > Log: > Don't wakeup the fdc worker thread once a second when idle. > > The fdc worker thread was using a one second timeout while waiting for > a new bio to arrive or for the device to detach. However, the driver > already does a wakeup when queueing a new bio or asking the thread to > detach, so the timeout only served to waste CPU time waking up the > thread once a second just so it could go right back to sleep. Use an > infinite timeout instead. > > Discussed with: phk > Sponsored by: Netflix Imho that was nice to have in 10.4. Any reason not to MFS? Thanks, -harry