From nobody Wed Jun 3 20:08:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gVzL54nnTz6gd09; Wed, 03 Jun 2026 20:09:01 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gVzL53zd6z4QWT; Wed, 03 Jun 2026 20:09:01 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780517341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P7gG8DHG/Y0nsWYAnKVsvwEez9oDQA0Txf5XZGbB7QA=; b=wnmZBa8DcdMsAB7XD0Wx8mXStmZbF1Uibol5/9pGtX9hCvZmSC1W63wxTaP672nClNgL8E X6yqaAVoKOeAn6d29ux/HZabfNgUftKgWDaTS3NFyi0XhfBkmqKfgadvIVYQAWljywHnnX IkgN4gAQHQmOQD2y9ddnYl2PSCk5+J0X9OxmTZmbF0M7kg75xyAKRFrodFfDwTl/CIxR1H lIzr0QihKWg0iGXVpqFjk4/cCIRwfMwnfq6b2bckgv4ACiL38jWn3EMHpOh107Wmop2iIG id35dA6pDCI2kTAhbGjR+7ciGZcW5PFJGb1KjDwZRa2+01YvINEGdZ3PO2zrdg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780517341; a=rsa-sha256; cv=none; b=pgEhpVXXju9JDZm6ZluoZn6PjUwjQyYUXzaSdcY0SdMpglLKaEID2Fg+2lj5ensXyOGbSz SOfrHl/ToMVj/NcQNkEAtp3n2Wmd9mP6KRbJFwKVxaEcKcngnAXGIajymnC2fIxtxks92i EeZESPOGHs5lGhcE+dQoEBJ0I8pkfpYKD20BqOlE+BCU1ZisQ9aFtn5oo5ZdK5IEFK5dt5 6k4pM3jMSks7IA/LtU9MkOj5znnNmDMSCQ4Vhv5t6j4hnM3IKA75Fe9JXpR3zU6UGdzMhf ei5tPd5u7byd5vNvcnm4YzLjl5dSEHPOD1kUu5W9VYyBHEY20OSZI8R6PR1K7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780517341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P7gG8DHG/Y0nsWYAnKVsvwEez9oDQA0Txf5XZGbB7QA=; b=Ub/Am97GLCz+HB28y2H/MZvhbkDc4eWEFVYP+z2gxMiY2ZR4ZIYF0ymzl+Kk+4dxJH2JDQ 9CeLw5KKEbfGo1MaCGJIl9gYq96AUDnaQd6x9Lvz+s0OXr+jVSVgUsywQf1x2z73ghW7lY N7aLvQJF/NhT1mGkRsyMK7pGggVFhOb9Tu9IkAJGHw/3Uq59ag2ocaXIDiu9ijp3jDUVZP Py6WY0dAGMdaVo4DkxnbK2aTfmmfns6rkWM9jQ5UTmOgqPTQRp8v4jj6Hfv8c2GEacGJ+o 13JGhMEIE7IwA0OfHxJmcsRr7Ez4hRB46H1dlrr/DKtHSPBWW4XAvonHIJKySQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gVzL402N0zQ89; Wed, 03 Jun 2026 20:08:59 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 3 Jun 2026 13:08:56 -0700 From: Gleb Smirnoff To: Kristof Provost , Ishan Agrawal Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Ishan Agrawal Subject: Re: git: 017690e50913 - main - netpfil: add PF netlink command decoding support Message-ID: References: <6a2028fd.30559.3287a30@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a2028fd.30559.3287a30@gitrepo.freebsd.org> On Wed, Jun 03, 2026 at 01:15:41PM +0000, Kristof Provost wrote: K> The branch main has been updated by kp: K> K> URL: https://cgit.FreeBSD.org/src/commit/?id=017690e509134422dbfa80316eab56d8d3f87065 K> K> commit 017690e509134422dbfa80316eab56d8d3f87065 K> Author: Ishan Agrawal K> AuthorDate: 2026-06-01 12:24:05 +0000 K> Commit: Kristof Provost K> CommitDate: 2026-06-03 08:52:06 +0000 K> K> netpfil: add PF netlink command decoding support K> K> Convert PFNL_CMD values in pf_nl.h from an enum to #define constants, K> add a pfnl_cmd table definition for mktable, and implement the K> corresponding command decoding helpers in libsysdecode. K> K> This allows mktable to generate PF netlink command lookup tables and K> enables symbolic decoding of PF netlink commands. K> K> Reviewed by: kp K> Signed-off-by: Ishan Agrawal K> Sponsored by: Google LLC (GSoC 2026) Sorry for not reviewing in time. I got question: why does this require ditching the enum and regressing down to preprocessor defines? -- Gleb Smirnoff